Fix friendly class name for nested types of class templates #27899
Conversation
The previous update in the logic missed the case that for "Class<T>::Nested" the parsing in handleTemplateArguments() should stop at the first colon and pass "Class<T>" to subFriendlyName (because reTemplateArgs expects the name to end with ">"). Rather than messing with reTemplateArgs, the problem is fixed by recognizing the colon after a class template as a break point in the parsing, and remove the second colon as well.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27899/11696
|
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: FWCore/Utilities @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test workflow 4.23,4.24,4.25,4.26,4.27,4.28,4.34,4.36,4.37 |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
PR description:
The previous update in the logic (#27861) missed the case that for
Class<T>::Nestedthe parsing inhandleTemplateArguments()should stop at the first colon and passClass<T>tosubFriendlyName()(becausereTemplateArgsexpects the name to end with>).Rather than messing with
reTemplateArgs, the problem is fixed by recognizing the colon after a class template as a break point in the parsing, and remove the second colon as well.PR validation:
Unit tests runs, previously failing workflow 4.23 runs.