Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test extension for context classes #279

Merged
merged 4 commits into from Aug 13, 2013
Merged

Unit test extension for context classes #279

merged 4 commits into from Aug 13, 2013

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Aug 9, 2013

Extend existing unit tests to cover the
content of the context classes as they are
passed to the services in the callback
functions.

@wddgit
Unit test extension for context classes
3b0e2de 
Extend existing unit tests to cover the
content of the context classes as they are
passed to the services in the callback
functions.
@ktf
Copy link
Contributor

ktf commented Aug 10, 2013

Looks like this does not work:

---> test TestIntegrationGetBy had ERRORS

Have a look at:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/84/ARCHITECTURE=slc5_amd64_gcc472/console

@ghost ghost assigned wddgit Aug 10, 2013
@Dr15Jones
Copy link
Contributor

Hi Giulio,
The test output is just complaining about the different name between the IB and CMSSW_7_0_0_pre1 (where I guess the comparison test file was generated). However, when I look at the files in git, I can't seem to find that output. Also, I see that none of the IBs have failed.

Chris

Christopher Jones
Fermi National Accelerator Laboratory
cdj@fnal.gov

On Aug 10, 2013, at 2:31 AM, Giulio Eulisse notifications@github.com wrote:

Looks like this does not work:

---> test TestIntegrationGetBy had ERRORS

Have a look at:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/84/ARCHITECTURE=slc5_amd64_gcc472/console

—
Reply to this email directly or view it on GitHub.

@Dr15Jones
Copy link
Contributor

Ah, I failed to see that this was a new pull request separate from the Service change and therefore hasn't been integrated and therefore isn't in an IB

@ktf
Copy link
Contributor

ktf commented Aug 11, 2013

Indeed. I think the best thing to do is simply to drop the release name from the comparison. @wddgit can you look into it on monday? Thanks.

@wddgit
Copy link
Contributor Author

wddgit commented Aug 12, 2013

I dropped the release name from the comparison so the unit test should be fixed in this pull request. It never needed to be there in the first place.

@ghost ghost assigned nclopezo Aug 13, 2013
@ktf
Copy link
Contributor

ktf commented Aug 13, 2013

@nclopezo can you test this again? running unit tests is enough.

@nclopezo
Copy link
Contributor

Hi,

I took these changes on top of CMSSW_7_0_X_2013-08-13-0200, all unit tests passed. You can see the logs here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/86/consoleFull

ktf added a commit that referenced this pull request Aug 13, 2013
@ktf
Merge pull request #279 from wddgit/unitTestServiceContexts
81aaba7 
Unit test extension for context classes
@ktf ktf merged commit 81aaba7 into cms-sw:CMSSW_7_0_X Aug 13, 2013
@wddgit wddgit deleted the unitTestServiceContexts branch November 8, 2013 19:17
parbol pushed a commit to parbol/cmssw that referenced this pull request Mar 5, 2015
@gpetruc
Merge pull request cms-sw#279 from emanueledimarco/CMGTools_from723_m…
febc405 
…onox

CMG Tools branch for MonoX analyses
makortel pushed a commit to makortel/cmssw that referenced this pull request Apr 22, 2015
@smuzaffar
Merge pull request cms-sw#279 from smuzaffar/master
b2accdc 
correct CMSDIST path use
abaty pushed a commit to abaty/cmssw that referenced this pull request May 14, 2020
@bi-ran @yetkinyilmaz
@mandrenguyen @mverwe @cfmcginn
flow cs subtraction, add jet sequences (cms-sw#279)
e7dede5 
* possibility of running the genjets for the signal sub-event only

* producer for genparticle collection of signal part only

* Signal filter for GenJets

* Adding filters to produce signal-only genparticles and genjets for embedded workflows, rather than only producing signal gen jets

* fix very rare case of seg fault (with debug statement)

* auto_ptr to unique_ptr migration (part 2)

for RecoHI/HiJetAlgos

* add fillDescriptions for SubEventGenJetProducer

* cs, pu hybrid subtraction

* fix defining pf particle tower producer twice

move producer to plugins

* add heavy ion jet reco sequence to aod task

* btagging info; function to generate jet sequences

adds pat jet sequences to jet task through a customise function. avoids
having to manually declare every module in the sequence once for every
jet radius.

* add gen jet sequences to miniaod

* add high purity track filter to jet sequence

* fix jecs for data and mc

* remove all ak8/puppi related modules

* keep only heavyion-style gen jets

Co-authored-by: Yetkin <yetkin.yilmaz@cern.ch>
Co-authored-by: Matthew <Matthew.Nguyen@cern.ch>
Co-authored-by: Marta <marta.verweij@cern.ch>
Co-authored-by: Chris <cfmcginn@mit.edu>
slava77 pushed a commit to slava77/cmssw that referenced this pull request Oct 9, 2021
@osschar
Merge pull request cms-sw#279 from trackreco/remove-OpenMP
b6a67e6 
comment out all omp refs but simd, change icc(gcc) flag to -q(f)openm…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nclopezo nclopezo

Labels
None yet
Projects
None yet
Milestone
CMSSW_7_0_0_pre3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wddgit @ktf @Dr15Jones @nclopezo