Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQMIO lumisection extraction script #27903

Merged
merged 7 commits into from Sep 18, 2019

Conversation

schneiml
Copy link
Contributor

@schneiml schneiml commented Aug 30, 2019

PR description:

This PR introduces a new tool to extract the histograms from DQMIO data (including per-lumi saved MEs), and repacks them into a format acceptable by DQMGUI.

There are various limitations on DQMGUI side regarding this data, and the navigation between lumisections is achieved by swapping run and ls numbers. Such files should never be uploaded to official DQMGUI instances, and are only to view specific data using a local GUI.

PR validation:

Introduces a new tool, no changes expected.

Instructions to run:

# 0. Connect to lxplus with a tunnel.
firefox http://localhost:8070/dqm/online-dev/ &
ssh -L 8070:localhost:8070 $USER@lxplus7.cern.ch

# 1. Setup a local DQMGUI
/bin/bash
export PATH=$PATH:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin
mkdir -p /tmp/$USER/testGui
cd /tmp/$USER/testGui
git clone git://github.com/dmwm/deployment.git
$PWD/deployment/Deploy -A slc7_amd64_gcc630 -r "comp=comp" \
  -R comp@HG1908e -t MYDEV -s "prep sw post" $PWD dqmgui/bare
source current/apps/dqmgui/128/etc/profile.d/env.sh
$PWD/current/config/dqmgui/manage -f online \
  start "I did read documentation"
exit

# 2. Setup the tool (no longer needed once this PR is merged)
cmsrel CMSSW_11_0_0_pre5
cd CMSSW_11_0_0_pre5/src/
cmsenv
git cms-merge-topic schneiml:dqm-harvestlumi-script
scram b -j8

# 3. Run the tool
voms-proxy-init --rfc --voms cms
dqmiolumiharvest.py -u http://localhost:8070/dqm/online-dev/ \
  --perlumionly -j10 \
  -m "JetMET/MET/*/*/METSig" \
  -r 301393 \
  /JetHT/Run2017C-25Jul2019_UL2017-v2/DQMIO

# 4. Wait for the GUI to index and enjoy your per-lumi plots!
# this can take a while, much longer than collecting the data...

Files are not yet accepted by the GUI, not sure why.
The GUI consumed the previous files, but Run/Lumi did not work...
Seems like this fixes reading TH1Fs.
mostly to make the output more readable when all we care about is per-lumi histos.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27903/11707

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @schneiml (Marcel Schneider) for master.

It involves the following packages:

DQMServices/Components

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 31, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2290/console Started: 2019/08/31 18:58

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5eb6ba/2290/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2955700
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2955357
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@fabiocos
Copy link
Contributor

@jfernan2 @andrius-k is there any issue with this PR? What is the plan for it?

@jfernan2
Copy link
Contributor

+1
@fabiocos
The script is working with test data, we were waiting for official perLS from 2017UL to make a larger test but I believe it can go in this round so far

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@jfernan2 @schneiml up to you to say, in my understanding it is a tool to be used by those who know what to do with it. But if you prefer to keep it on hold to better test it fine for me, I understood it was already proved to work

@fioriNTU
Copy link
Contributor

@fabiocos your understanding is correct, the tool is tested and it is working as expected. It has recently be tested also in UL2017 ZeroBias successfully. So, please, go ahead with this PR, at the end it doesn't touch any production workflow.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d828cac into cms-sw:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants