More verbose error if plugin could not be loaded due to missing shared library #27908

guitargeek · 2019-08-31T09:06:51Z

PR description:

The error message that you get if you delete plugin that is in the realease in your work area, and then try to use that plugin, is not very informative. The way this is handled is by referring to "poisoned" libraries in the work area, which actually don't exist. So you get some error like this:

----- Begin Fatal Exception 04-Sep-2019 13:39:04 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
unable to load /scratch/rembser/cmssw/dev/CMSSW_11_0_X_2019-09-02-2300/lib/slc7_amd64_gcc700/poisoned/plugin-poisoned-RecoEgammaElectronIdentificationPlugins.so because /scratch/rembser/cmssw/dev/CMSSW_11_0_X_2019-09-02-2300/lib/slc7_amd64_gcc700/poisoned/plugin-poisoned-RecoEgammaElectronIdentificationPlugins.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

However, it would be great (in particular to catch mistakes in cleanup PRs) if the message told you the name of the plugin it tried to load in the first place. I propose to add this information as a context to the exception (thanks @Dr15Jones for the implementation idea). The error message would look like this then:

----- Begin Fatal Exception 04-Sep-2019 13:39:04 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin ElectronMVANtuplizer
Exception Message:
unable to load /scratch/rembser/cmssw/dev/CMSSW_11_0_X_2019-09-02-2300/lib/slc7_amd64_gcc700/poisoned/plugin-poisoned-RecoEgammaElectronIdentificationPlugins.so because /scratch/rembser/cmssw/dev/CMSSW_11_0_X_2019-09-02-2300/lib/slc7_amd64_gcc700/poisoned/plugin-poisoned-RecoEgammaElectronIdentificationPlugins.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

We talked a bit about this already a little bit in PR #27522 (in particular #27522 (comment)).

While investigating how to do that I "git grepped" for "SharedLibrary" and therefore found by chance many places where SharedLibrary.h is included but not used. We could also remove these as a little side effect of this PR.

PR validation:

CMSSW compiles, local matrix tests pass.

if this PR is a backport please specify the original PR:

No backport intended.

cmsbuild · 2019-08-31T09:07:22Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-08-31T09:13:42Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27908/11713

This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27908/11713/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27908/11713/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2019-08-31T09:25:18Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-08-31T09:31:00Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27908/11714

This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27908/11714/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27908/11714/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2019-08-31T09:42:08Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-08-31T09:49:07Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27908/11715

This PR adds an extra 36KB to repository

cmsbuild · 2019-08-31T09:49:38Z

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CondCore/AlignmentPlugins
CondCore/CondDB
CondCore/RunInfoPlugins
CondCore/SiStripPlugins
CondCore/Utilities
FWCore/PluginManager

@ggovi, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @wddgit, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2019-09-01T20:23:27Z

please test

cmsbuild · 2019-09-01T20:24:42Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2294/console Started: 2019/09/01 22:25

cmsbuild · 2019-09-04T11:50:52Z

Pull request #27908 was updated. @ggovi, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

fabiocos · 2019-09-04T16:28:17Z

please test

cmsbuild · 2019-09-04T16:28:45Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2361/console Started: 2019/09/04 18:29

Dr15Jones · 2019-09-04T17:21:44Z

+1

cmsbuild · 2019-09-04T18:14:05Z

+1
Tested at: 41c52ca
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a33b1f/2361/summary.html

cmsbuild · 2019-09-04T18:14:08Z

Comparison job queued.

cmsbuild · 2019-09-04T20:19:11Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a33b1f/2361/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2955700
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2955358
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 145 log files, 15 edm output root files, 34 DQM output files

fabiocos · 2019-09-05T09:07:51Z

@ggovi the db part of this PR looks a technical cleaning, could you please have a look?

ggovi · 2019-09-09T15:03:02Z

+1

cmsbuild · 2019-09-09T15:03:36Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-09-09T20:24:27Z

+1

cmsbuild added this to the CMSSW_11_0_X milestone Aug 31, 2019

cmsbuild added code-checks-pending comparison-pending core-pending db-pending labels Aug 31, 2019

cmsbuild added orp-pending pending-signatures tests-pending labels Aug 31, 2019

cmsbuild added code-checks-rejected and removed code-checks-pending labels Aug 31, 2019

guitargeek added 2 commits August 31, 2019 11:24

indicate which plugin could not be loaded in PluginManager

992b4d9

remove some unused includes in CondCore

4161a93

cmsbuild added code-checks-pending and removed code-checks-rejected labels Aug 31, 2019

cmsbuild added code-checks-rejected and removed code-checks-pending labels Aug 31, 2019

code-format CondCore/CondDB/test/testTempWrapper_0.cpp

54661f3

cmsbuild added code-checks-pending and removed code-checks-rejected labels Aug 31, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 31, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 4, 2019

cmsbuild added tests-started and removed tests-pending labels Sep 4, 2019

cmsbuild added core-approved and removed core-pending labels Sep 4, 2019

cmsbuild added tests-approved and removed tests-started labels Sep 4, 2019

cmsbuild added comparison-available and removed comparison-pending labels Sep 4, 2019

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Sep 9, 2019

cmsbuild added orp-approved and removed orp-pending labels Sep 9, 2019

cmsbuild merged commit da056ef into cms-sw:master Sep 9, 2019

guitargeek deleted the PluginLoadError branch September 9, 2019 22:33

smuzaffar mentioned this pull request May 29, 2020

make plugin factory report which plugin was loaded in load exception #17938

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More verbose error if plugin could not be loaded due to missing shared library #27908

More verbose error if plugin could not be loaded due to missing shared library #27908

guitargeek commented Aug 31, 2019 •

edited

cmsbuild commented Aug 31, 2019

cmsbuild commented Aug 31, 2019

cmsbuild commented Aug 31, 2019

cmsbuild commented Aug 31, 2019

cmsbuild commented Aug 31, 2019

cmsbuild commented Aug 31, 2019

cmsbuild commented Aug 31, 2019

smuzaffar commented Sep 1, 2019

cmsbuild commented Sep 1, 2019 •

edited

cmsbuild commented Sep 4, 2019

fabiocos commented Sep 4, 2019

cmsbuild commented Sep 4, 2019 •

edited

Dr15Jones commented Sep 4, 2019

cmsbuild commented Sep 4, 2019

cmsbuild commented Sep 4, 2019

cmsbuild commented Sep 4, 2019

fabiocos commented Sep 5, 2019

ggovi commented Sep 9, 2019

cmsbuild commented Sep 9, 2019

fabiocos commented Sep 9, 2019

More verbose error if plugin could not be loaded due to missing shared library #27908

More verbose error if plugin could not be loaded due to missing shared library #27908

Conversation

guitargeek commented Aug 31, 2019 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Aug 31, 2019

cmsbuild commented Aug 31, 2019

cmsbuild commented Aug 31, 2019

cmsbuild commented Aug 31, 2019

cmsbuild commented Aug 31, 2019

cmsbuild commented Aug 31, 2019

cmsbuild commented Aug 31, 2019

smuzaffar commented Sep 1, 2019

cmsbuild commented Sep 1, 2019 • edited

cmsbuild commented Sep 4, 2019

fabiocos commented Sep 4, 2019

cmsbuild commented Sep 4, 2019 • edited

Dr15Jones commented Sep 4, 2019

cmsbuild commented Sep 4, 2019

cmsbuild commented Sep 4, 2019

cmsbuild commented Sep 4, 2019

fabiocos commented Sep 5, 2019

ggovi commented Sep 9, 2019

cmsbuild commented Sep 9, 2019

fabiocos commented Sep 9, 2019

guitargeek commented Aug 31, 2019 •

edited

cmsbuild commented Sep 1, 2019 •

edited

cmsbuild commented Sep 4, 2019 •

edited