Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixLumisPerJobSplittingFor2018 #27911

Merged

Conversation

srimanob
Copy link
Contributor

PR description:

Fix LumisPerJobSplitting For 2018 which changed from Prompt to Offline in
https://github.com/cms-sw/cmssw/pull/26417/files

PR validation:

https://cmsweb.cern.ch/reqmgr2/fetch?rid=request-srimanob_RVCMSSW_11_0_0_pre5RunEGamma2018C__PHATTEST_RelVal_2018C_190831_214637_5994

if this PR is a backport please specify the original PR:

backport of #27910

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 31, 2019

A new Pull Request was created by @srimanob (Phat Srimanobhas) for CMSSW_10_6_X.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @prebello, @chayanit, @zhenhu, @kpedro88, @pgunnell can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #27911 was updated. @cmsbuild, @prebello, @chayanit, @zhenhu, @kpedro88, @pgunnell can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #27911 was updated. @cmsbuild, @prebello, @chayanit, @zhenhu, @kpedro88, @pgunnell can you please check and sign again.

@chayanit
Copy link

chayanit commented Sep 1, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2293/console Started: 2019/09/01 22:11

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b41ee/2293/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211049
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3210713
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@chayanit
Copy link

chayanit commented Sep 3, 2019

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Sep 3, 2019

backport of #27910

@kpedro88
Copy link
Contributor

kpedro88 commented Sep 3, 2019

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Sep 4, 2019

+1

@cmsbuild cmsbuild merged commit 84f926f into cms-sw:CMSSW_10_6_X Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants