Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a data based relval test wf with lumi boundary crossing #27937

Merged
merged 2 commits into from Sep 11, 2019

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Sep 5, 2019

PR description:

New test wfs 136.8861 and 136.8862 (EGamma Run2018D) are proposed, expanding 136.886 with instructions to force a lumi boundary crossing within a short (100 events) run, and enabling nConcurrentlumis as discussed in #26348 . One test uses two lumi sections from different runs, while the other lumi sections from the same run. These tests are supposed to serve developments like those proposed by the Core FWK team in #26592.

PR validation:

The wf 136.8861 and 136.8862 run till the end.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27937/11778

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2019

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @prebello, @chayanit, @zhenhu, @kpedro88, @pgunnell can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@@ -478,6 +482,10 @@
### LS2 - MWGR ###
steps['RunCosmics2019']={'INPUT':InputInfo(dataSet='/ExpressCosmics/Commissioning2019-Express-v1/FEVT',label='2019GR3',run=[330098],events=100000,location='STD')}

#### Test of lumi section boundary crossing with run2 2018D ####
Run2018Dml={320822: [[1,1]] , 320823: [[1,1]]}
steps['RunEGamma2018Dml']={'INPUT':InputInfo(dataSet='/EGamma/Run2018D-v1/RAW',label='2018D',events=100000,location='STD', ls=Run2018Dml)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This leads to run boundary (between runs 320822 and 320823) in addition to lumi boundary, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I am working to a revised version that adds a lumi boundary only workflow

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27937/11795

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

Pull request #27937 was updated. @cmsbuild, @prebello, @chayanit, @zhenhu, @kpedro88, @pgunnell can you please check and sign again.

@fabiocos
Copy link
Contributor Author

fabiocos commented Sep 6, 2019

please test workflow 136.8861,136.8862

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2398/console Started: 2019/09/06 13:57

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-823279/2398/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-823279/136.8861_RunEGamma2018Dml1+RunEGamma2018Dml1+HLTDR2_2018ml+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQMml+HARVEST2018_L1TEgDQM_Prompt
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-823279/136.8862_RunEGamma2018Dml2+RunEGamma2018Dml2+HLTDR2_2018ml+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQMml+HARVEST2018_L1TEgDQM_Prompt

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2955796
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2955454
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@chayanit
Copy link

+1

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor Author

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants