New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-sim44 Make changes to conform G4/GV Comparison #27938
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27938/11779
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Geometry/CMSCommonData @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@@ -50,6 +50,7 @@ | |||
PhysicsTablesDirectory = cms.untracked.string('PhysicsTables'), | |||
StorePhysicsTables = cms.untracked.bool(False), | |||
RestorePhysicsTables = cms.untracked.bool(False), | |||
UseParametrisedEMPhysics = cms.untracked.bool(False), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be true by default to keep previous behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right - corrected
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27938/11782
|
Pull request #27938 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again. |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+upgrade |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Make option for registering the EM parametrization process and add a region for NoSD option. These are useful for Geant4/GeantV comparisons
PR validation:
Tested with standard run flow matrix
if this PR is a backport please specify the original PR:
Nothing special