Fixing VID return value for HEEP Trk Iso: 11_0_X

[Sam-Harper]

PR description:

Dear All,

This PR fixes a bug which occurred when unifying the heep & non-HEEP track isolation VID cut. While the correct value is cut upon, the returned value is incorrect and this fixes it.

Many thanks to @oglez (Oscar Gonzalez Lopez) for spotting and reporting the issue!

This bug has no impact on anything centrally run (we dont retrieve this value in any e/gamma workflow, its purely for users) so we expect zero changes. However our users may use this (and in fact do) so it needs to be fixed, also 10_6_X.

On code, there was the suggestion that the cut function should just use the result of the value function, on the face of it its a good idea however it means we have an extra dynamic cast + function call hence I kept it as is.

Best,
Sam

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27944/11792

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Sam-Harper (Sam Harper) for master.

It involves the following packages:

RecoEgamma/ElectronIdentification

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jainshilpi, @varuns23, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2401/console Started: 2019/09/06 14:15

[cmsbuild]

+1
Tested at: e87c424
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ee17e/2401/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ee17e/2401/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2955796
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2955454
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[slava77]

+1

for #27944 e87c424

• code changes are in line with the PR description
• jenkins tests pass and comparisons with the baseline show no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1