Ignore sanitize options when generating CondFormat serialzations #27952
Conversation
The sanitize compiler options are not useful when all we need is the compiler to do C++ parsing, not code generation. Ignoring the option avoids problems when clang does not support the same options as gcc.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27952/11808
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: CondFormats/Serialization @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
@smuzaffar @fabiocos this fixes the build problems in CMSSW_11_0_ASAN_X_2019-09-06-2300. It should have no affect on any other build. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@ggovi the fix looks technical, could you please have a look? |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
The sanitize compiler options are not useful when all we need is the compiler to do C++ parsing, not code generation. Ignoring the option avoids problems when clang does not support the same options as gcc.
PR validation:
Using this pull request one can now generate serialization code using CMSSW_11_0_ASAN_X_2019-09-06-2300.