New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SimG4CMS/PPS dependency to geant4core only #27953
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27953/11812
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: SimG4CMS/PPS @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
@smuzaffar @civanch do you agree? |
The tests are being triggered in jenkins. |
yes agree @fabiocos |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Follow-up of #27673 : the BuildFile.xml of SimG4CMS/PPS does not need to depend on the while geant4, but geant4core is enough as for the other similar packages.
PR validation:
Code compiles without issues.