Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SimG4CMS/PPS dependency to geant4core only #27953

Merged
merged 1 commit into from Sep 9, 2019

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Sep 9, 2019

PR description:

Follow-up of #27673 : the BuildFile.xml of SimG4CMS/PPS does not need to depend on the while geant4, but geant4core is enough as for the other similar packages.

PR validation:

Code compiles without issues.

@cmsbuild cmsbuild added this to the CMSSW_11_0_X milestone Sep 9, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27953/11812

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

SimG4CMS/PPS

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Sep 9, 2019

please test

@fabiocos
Copy link
Contributor Author

fabiocos commented Sep 9, 2019

@smuzaffar @civanch do you agree?

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2429/console Started: 2019/09/09 10:09

@smuzaffar
Copy link
Contributor

yes agree @fabiocos

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3fe25/2429/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2957224
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2956882
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@civanch
Copy link
Contributor

civanch commented Sep 9, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor Author

fabiocos commented Sep 9, 2019

+1

@cmsbuild cmsbuild merged commit 6b98c6c into cms-sw:master Sep 9, 2019
@fabiocos fabiocos deleted the fc-fixbuildfile branch September 25, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants