Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD4hep: Strip off Residual Namespace while Calculating the History #27954

Merged
merged 1 commit into from Sep 10, 2019

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Sep 9, 2019

PR description:

  • Some of the algorithms rely on the volumes with namespaces defined. This is taken into an account when the history is calculated.
  • Navigate up the tree to the top volume

PR validation:

unit tests and relval tests

if this PR is a backport please specify the original PR:

no backport is needed

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27954/11815

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@vargasa this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ianna
Copy link
Contributor Author

ianna commented Sep 9, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2431/console Started: 2019/09/09 14:35

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eaf330/2431/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2957224
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2956882
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented Sep 9, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants