New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove histogrammar (obsolete package) #27969
Conversation
please test |
The code-checks are being triggered in jenkins. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27969/11847
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: PhysicsTools/PythonAnalysis @cmsbuild, @santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
@davidlange6 this package looks unused within CMSSW, apart for the test removed here (and introduced by you 3 years ago). So I assume this should be ok, do you know whether anybody was giving it a try? |
Comparison job queued. |
as its analysis related, people using it most likely won't be doing so within cmssw. Anyway, its ok to remove - its been replaced quite a while ago and no longer supported
… On Sep 11, 2019, at 11:09 AM, Fabio Cossutti ***@***.***> wrote:
@davidlange6 this package looks unused within CMSSW, apart for the test removed here (and introduced by you 3 years ago). So I assume this should be ok, do you know whether anybody was giving it a try?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Comparison is ready Comparison Summary:
|
@santocch please have a look, I plan to integrate it into next IB |
+1 |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
removes unit tests for histogrammar python package (removed in cms-sw/cmsdist#5219)
PR validation:
fixes test failures in cms-sw/cmsdist#5219