New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracker Alignment: update PV Validation tool as used in Ultra-Legacy #27984
Tracker Alignment: update PV Validation tool as used in Ultra-Legacy #27984
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27984/11875
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Alignment/OfflineValidation @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The purpose of this PR is to update the code of the PV Validation tool used in the tracker alignment to the standard used during the Run-2 Ultra-Legacy campaigns.
N.B.: the total amount of changes is large, but is actually due to the obligatory code-format that I've factorized in a6fd139
PR validation:
PR passes compilation and standard unit tests.
Extensive usage of the tool has been done during the Ultra-Legacy campaign, including the production of the recently approved results (see Approved DPS).
Here an example of the approved results for 2017:
if this PR is a backport please specify the original PR:
This PR is not a backport
cc:
@adewit @connorpa