Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM tau miniaod validation CMSSW_106X #27985

Merged

Conversation

aspiezia
Copy link
Contributor

PR description:

Backport of #27925
As in the previous pull request:
This PR has been done in order to add some histograms for the tau validation. The histograms are meant to validate the miniAOD part, in particolar for what it concern the DeepTau discriminators that can be checked only at miniAOD level. @rmanzoni @roger-wolf

PR validation:

First the changes have been tested with some RelVal samples in order to check that the histograms are created and filled in a sensible way.
Then, the instructions of https://cms-sw.github.io/PRWorkflow.html (see [*]) have been followed.

[*]
cd src
scram b distclean
git cms-checkdeps -a -A
scram b -j 8
scram b runtests
runTheMatrix.py -l limited -i all --ibeos

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aspiezia for CMSSW_10_6_X.

It involves the following packages:

Configuration/StandardSequences
Validation/RecoTau

@andrius-k, @kmaeshima, @schneiml, @kpedro88, @cmsbuild, @franzoni, @jfernan2, @fioriNTU, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 13, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2506/console Started: 2019/09/13 11:40

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e51448/2506/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3210961
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3210626
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 720.528 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 20034.0,... ): 6.549 KiB RecoTauV/miniAODValidationRealElectronsData
  • DQMHistoSizes: changed ( 20034.0,... ): 6.502 KiB RecoTauV/miniAODValidationRealMuonsData
  • DQMHistoSizes: changed ( 20034.0,... ): 6.443 KiB RecoTauV/miniAODValidationRealData
  • DQMHistoSizes: changed ( 20034.0,... ): 6.385 KiB RecoTauV/miniAODValidationZTT
  • DQMHistoSizes: changed ( 20034.0,... ): 6.385 KiB RecoTauV/miniAODValidationQCD
  • DQMHistoSizes: changed ( 20034.0,... ): 6.385 KiB RecoTauV/miniAODValidationZMM
  • DQMHistoSizes: changed ( 20034.0,... ): 6.385 KiB RecoTauV/miniAODValidationZEE
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@jfernan2
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

+operations

the backport of the configurations updates in this PR is correct

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5f41720 into cms-sw:CMSSW_10_6_X Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants