Removed implicitly dropped move assignment from RectangularEtaPhiTrackingRegion #27993
Conversation
…kingRegion The compiler was implictly not implementing the move assignment operator even though it was marked as '=default'. The reason is there is a const member data which prohibits any assignments.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27993/11889
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: RecoTracker/TkTrackingRegions @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
Is it safe to delete a method which was explicitly included in the class? Well, apparently yes, because all tests run succesfully to conclusion: this demonstrates that it is never used in the current cmssw code. |
|
@perrotta the const is not actually fixed at compile time, the main constructor is passed a value used to set that const. Therefore making it static will not work. |
|
+1
|
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
The compiler was implictly not implementing the move assignment operator even though it was marked as '=default'. The reason is there is a const member data which prohibits any assignments.
PR validation:
Compiling using clang no longer gives a warning.