New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ExpandVisitor.result() to work also with an empty result #28006
Conversation
If a cms.Sequence holds only tasks, the list of sequenceable elements is empty, and self.l[0] leads to an IndexError.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28006/11910
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: FWCore/ParameterSet @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
type bug-fix |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
PR description:
If a
cms.Sequence
holds only Tasks, theSequence.expandAndClone()
fails with anIndexError
fromExpandVisitor.result()
. There the internal list of sequenceable objects is empty, andself.l[0]
leads to anIndexError
. This PR fixes the error by first checking the length of the sequenceable object list, and if empty, return the sequence type with only the Task part.The error was reported in https://hypernews.cern.ch/HyperNews/CMS/get/swDevelopment/3538.html
PR validation:
Unit tests run.