Phase2-hgx220 Convert DDHGCalEEAlgo to DD4Hep format #28011

bsunanda · 2019-09-17T00:41:48Z

PR description:

Convert DDHGCalEEAlgo from DDD to DD4Hep scenario (Raman Shegal)

PR validation:

Tested with scripts in Geometry/HGCalCommonData/test/python

if this PR is a backport please specify the original PR:

Nothing special

cmsbuild · 2019-09-17T00:42:16Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-09-17T00:49:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28011/11916

This PR adds an extra 20KB to repository

cmsbuild · 2019-09-17T00:49:36Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2019-09-17T00:50:27Z

@cmsbuild Please test

cmsbuild · 2019-09-17T00:50:56Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2541/console Started: 2019/09/17 02:51

cmsbuild · 2019-09-17T02:23:04Z

+1
Tested at: 8faa619
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-867389/2541/summary.html

cmsbuild · 2019-09-17T02:23:07Z

Comparison job queued.

cmsbuild · 2019-09-17T04:30:38Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-867389/2541/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2957336
DQMHistoTests: Total failures: 128
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2956867
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 145 log files, 15 edm output root files, 34 DQM output files

kpedro88 · 2019-09-17T15:49:20Z

+upgrade

cvuosalo · 2019-09-17T20:20:39Z

Geometry/HGCalCommonData/plugins/dd4hep/DDHGCalEEAlgo.cc

+
+        dd4hep::Position r1(0, 0, zz);
+        dd4hep::Rotation3D rot;
+        mother_.placeVolume(glog, copy, dd4hep::Transform3D(rot, r1));


According to #27997, it looks like the Rotation3D is not needed. Have you seen that PR?

Yes - now I removed this

cvuosalo · 2019-09-17T20:22:27Z

Geometry/HGCalCommonData/plugins/dd4hep/DDHGCalEEAlgo.cc

+#endif
+
+            dd4hep::Position tran(xpos, ypos, 0.0);
+            dd4hep::Rotation3D rotation;


Unneeded Rotation3D?

Taken care of that

cmsbuild · 2019-09-18T15:39:16Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-09-18T15:46:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28011/11935

This PR adds an extra 20KB to repository

cmsbuild · 2019-09-18T15:47:21Z

Pull request #28011 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

bsunanda · 2019-09-18T16:10:15Z

@cmsbuild Please test

cmsbuild · 2019-09-18T16:10:39Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2564/console Started: 2019/09/18 18:11

cmsbuild · 2019-09-18T17:43:58Z

+1
Tested at: 01bcb50
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-867389/2564/summary.html

cmsbuild · 2019-09-18T17:44:02Z

Comparison job queued.

cmsbuild · 2019-09-18T19:28:45Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-867389/2564/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2957336
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2956994
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 145 log files, 15 edm output root files, 34 DQM output files

kpedro88 · 2019-09-19T14:42:38Z

+upgrade

cvuosalo · 2019-09-19T16:30:17Z

+1

cmsbuild · 2019-09-19T16:30:46Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-09-19T20:28:48Z

+1

Convert DDHGCalEEAlgo to DD4Hep format

8faa619

cmsbuild added this to the CMSSW_11_0_X milestone Sep 17, 2019

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Sep 17, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 17, 2019

cmsbuild added tests-started and removed tests-pending labels Sep 17, 2019

cmsbuild added tests-approved and removed tests-started labels Sep 17, 2019

cmsbuild added comparison-available and removed comparison-pending labels Sep 17, 2019

cmsbuild added upgrade-approved and removed upgrade-pending labels Sep 17, 2019

cvuosalo reviewed Sep 17, 2019

View reviewed changes

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 18, 2019

cmsbuild added tests-started and removed tests-pending labels Sep 18, 2019

cmsbuild added tests-approved and removed tests-started labels Sep 18, 2019

cmsbuild added comparison-available and removed comparison-pending labels Sep 18, 2019

cmsbuild added upgrade-approved and removed upgrade-pending labels Sep 19, 2019

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Sep 19, 2019

cmsbuild added orp-approved and removed orp-pending labels Sep 19, 2019

cmsbuild merged commit ef7aec7 into cms-sw:master Sep 19, 2019

fabiocos mentioned this pull request Oct 11, 2019

EgammaV/ConversionValidator DQM ouptut is unstable in workflow 11634 #28072

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-hgx220 Convert DDHGCalEEAlgo to DD4Hep format #28011

Phase2-hgx220 Convert DDHGCalEEAlgo to DD4Hep format #28011

bsunanda commented Sep 17, 2019

cmsbuild commented Sep 17, 2019

cmsbuild commented Sep 17, 2019

cmsbuild commented Sep 17, 2019

bsunanda commented Sep 17, 2019

cmsbuild commented Sep 17, 2019 •

edited

cmsbuild commented Sep 17, 2019

cmsbuild commented Sep 17, 2019

cmsbuild commented Sep 17, 2019

kpedro88 commented Sep 17, 2019

cvuosalo Sep 17, 2019

bsunanda Sep 18, 2019

cvuosalo Sep 17, 2019

bsunanda Sep 18, 2019

cmsbuild commented Sep 18, 2019

cmsbuild commented Sep 18, 2019

cmsbuild commented Sep 18, 2019

bsunanda commented Sep 18, 2019

cmsbuild commented Sep 18, 2019 •

edited

cmsbuild commented Sep 18, 2019

cmsbuild commented Sep 18, 2019

cmsbuild commented Sep 18, 2019

kpedro88 commented Sep 19, 2019

cvuosalo commented Sep 19, 2019

cmsbuild commented Sep 19, 2019

fabiocos commented Sep 19, 2019

Phase2-hgx220 Convert DDHGCalEEAlgo to DD4Hep format #28011

Phase2-hgx220 Convert DDHGCalEEAlgo to DD4Hep format #28011

Conversation

bsunanda commented Sep 17, 2019

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Sep 17, 2019

cmsbuild commented Sep 17, 2019

cmsbuild commented Sep 17, 2019

bsunanda commented Sep 17, 2019

cmsbuild commented Sep 17, 2019 • edited

cmsbuild commented Sep 17, 2019

cmsbuild commented Sep 17, 2019

cmsbuild commented Sep 17, 2019

kpedro88 commented Sep 17, 2019

cvuosalo Sep 17, 2019

Choose a reason for hiding this comment

bsunanda Sep 18, 2019

Choose a reason for hiding this comment

cvuosalo Sep 17, 2019

Choose a reason for hiding this comment

bsunanda Sep 18, 2019

Choose a reason for hiding this comment

cmsbuild commented Sep 18, 2019

cmsbuild commented Sep 18, 2019

cmsbuild commented Sep 18, 2019

bsunanda commented Sep 18, 2019

cmsbuild commented Sep 18, 2019 • edited

cmsbuild commented Sep 18, 2019

cmsbuild commented Sep 18, 2019

cmsbuild commented Sep 18, 2019

kpedro88 commented Sep 19, 2019

cvuosalo commented Sep 19, 2019

cmsbuild commented Sep 19, 2019

fabiocos commented Sep 19, 2019

cmsbuild commented Sep 17, 2019 •

edited

cmsbuild commented Sep 18, 2019 •

edited