Simplify jet daughter processing in DeepBoostedJet

[hqucms]

PR description:

This PR simplifies the treatment of Puppi jet daughters in DeepAK8. In the past, we rely on a postfix string to distinguish whether the AK8 jets have puppi scaled daughters or not, which is quite fragile. Now we unifies it to always first get the original candidate (via the key(), inspired by @raggleton's RekeyJets) and then scaled it by the puppi weight.

PR validation:

Tested in a boosted TT sample and no change in the discriminator outputs found.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28035/11962

• This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28035/11962/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28035/11962/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28035/11963

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @hqucms (Huilin Qu) for master.

It involves the following packages:

PhysicsTools/PatAlgos
RecoBTag/FeatureTools

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @emilbols, @HeinerTholen, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @acaudron, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2590/console Started: 2019/09/20 13:07

[cmsbuild]

+1
Tested at: c84f658
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2778ea/2590/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2778ea/2590/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2958092
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2957749
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[perrotta]

@hqucms ; can this be tested in any standard workflow, or do you have to run something manually? Please provide a recipe for testing, in case this is not run in one of the automatically tested workflows.

[hqucms]

@perrotta DeepAK8 is run in the standard MiniAOD/NanoAOD workflows now so it should be covered.

[perrotta]

+1

• It unifies the jet daughter processing, whether or not those daughters are already scaled by puppi weight; the implementation follows what is in the PR description
• Jenkins tests pass and show no differences
• Larger tests are reported in the PR description, where no change in the discriminator outputs are found

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1