RPCDD4HEP bis #28036

slomeo · 2019-09-20T09:27:07Z

PR description:

DD4HEP migration for RPC

Test: see pdf files
Canvas_1.pdf
Canvas_2.pdf
Canvas_3.pdf
Canvas_4.pdf
Canvas_5.pdf
Canvas_6.pdf
Canvas_7.pdf
Canvas_8.pdf

made by validation process

cmsbuild · 2019-09-20T09:27:35Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-09-20T09:33:54Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28036/11964

This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28036/11964/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28036/11964/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28036/11964/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28036/11964/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2019-09-22T13:08:27Z

The code-checks are being triggered in jenkins.

slomeo · 2019-09-22T13:10:36Z

I have run "scram build code-checks" and "scram build code-format"

cmsbuild · 2019-09-22T13:16:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28036/11976

This PR adds an extra 36KB to repository

cmsbuild · 2019-09-22T13:18:41Z

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

Geometry/MuonNumbering
Geometry/RPCGeometryBuilder

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@ptcox this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

fabiocos · 2019-09-22T14:35:23Z

Geometry/MuonNumbering/src/RPCNumberingScheme.cc

@@ -34,6 +42,13 @@ void RPCNumberingScheme::initMe(const MuonDDDConstants& muonConstants) {
 }

 int RPCNumberingScheme::baseNumberToUnitNumber(const MuonBaseNumber& num) {
+  const int mylevel = num.getLevels();
+  //cout<<"------------myDEBUG DDD-------------------------------------------"<<endl;


@slomeo please avoid commented printout and use the MessageLogger instead (possibly with pre-processor conditions)

@fabiocos I deleted all not necessary "cout" and "include"

@slomeo please avoid commented printout and use the MessageLogger instead (possibly with pre-processor conditions)

fabiocos · 2019-09-22T14:36:47Z

please test

cmsbuild · 2019-09-22T14:37:08Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2610/console Started: 2019/09/22 16:37

cmsbuild · 2019-09-28T11:02:46Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-09-28T11:09:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28036/12064

This PR adds an extra 76KB to repository

cmsbuild · 2019-09-28T11:10:21Z

Pull request #28036 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

fabiocos · 2019-09-29T19:56:14Z

please test

cmsbuild · 2019-09-29T19:56:38Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2720/console Started: 2019/09/29 21:57

cmsbuild · 2019-09-29T21:23:24Z

+1
Tested at: aa66b38
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2fbe6f/2720/summary.html

cmsbuild · 2019-09-29T21:23:26Z

Comparison job queued.

cmsbuild · 2019-09-29T23:26:45Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2fbe6f/2720/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2958092
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2957750
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 145 log files, 15 edm output root files, 34 DQM output files

ianna · 2019-09-30T12:48:20Z

+1

cmsbuild · 2019-09-30T12:48:47Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-10-01T20:44:58Z

+1

slomeo added 6 commits September 20, 2019 10:06

test RPC migration

82b5532

update 1 (solved rot differences DD and DD4HEP)

0f56c41

update: (Roll OK) starting debug for nStrips

42d5333

update: probably found code for nstrips comparison

f011a96

final update: strips ok

66db227

DD4HEP migration for RPC: completed

850e3e2

cmsbuild added this to the CMSSW_11_0_X milestone Sep 20, 2019

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending labels Sep 20, 2019

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 20, 2019

update after scram build code-checks and scram build code-format

a794bc3

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 22, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 22, 2019

fabiocos reviewed Sep 22, 2019

View reviewed changes

cmsbuild removed the tests-pending label Sep 22, 2019

cmsbuild added comparison-pending geometry-pending pending-signatures tests-pending labels Sep 28, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 28, 2019

cmsbuild added tests-started and removed tests-pending labels Sep 29, 2019

cmsbuild added tests-approved and removed tests-started labels Sep 29, 2019

cmsbuild added comparison-available and removed comparison-pending labels Sep 29, 2019

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Sep 30, 2019

cmsbuild added orp-approved and removed orp-pending labels Oct 1, 2019

cmsbuild merged commit 472e07d into cms-sw:master Oct 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RPCDD4HEP bis #28036

RPCDD4HEP bis #28036

slomeo commented Sep 20, 2019

cmsbuild commented Sep 20, 2019

cmsbuild commented Sep 20, 2019

cmsbuild commented Sep 22, 2019

slomeo commented Sep 22, 2019

cmsbuild commented Sep 22, 2019

cmsbuild commented Sep 22, 2019

fabiocos Sep 22, 2019

slomeo Sep 23, 2019

fabiocos commented Sep 22, 2019

cmsbuild commented Sep 22, 2019 •

edited

cmsbuild commented Sep 28, 2019

cmsbuild commented Sep 28, 2019

cmsbuild commented Sep 28, 2019

fabiocos commented Sep 29, 2019

cmsbuild commented Sep 29, 2019 •

edited

cmsbuild commented Sep 29, 2019

cmsbuild commented Sep 29, 2019

cmsbuild commented Sep 29, 2019

ianna commented Sep 30, 2019

cmsbuild commented Sep 30, 2019

fabiocos commented Oct 1, 2019

RPCDD4HEP bis #28036

RPCDD4HEP bis #28036

Conversation

slomeo commented Sep 20, 2019

PR description:

cmsbuild commented Sep 20, 2019

cmsbuild commented Sep 20, 2019

cmsbuild commented Sep 22, 2019

slomeo commented Sep 22, 2019

cmsbuild commented Sep 22, 2019

cmsbuild commented Sep 22, 2019

fabiocos Sep 22, 2019

Choose a reason for hiding this comment

slomeo Sep 23, 2019

Choose a reason for hiding this comment

fabiocos commented Sep 22, 2019

cmsbuild commented Sep 22, 2019 • edited

cmsbuild commented Sep 28, 2019

cmsbuild commented Sep 28, 2019

cmsbuild commented Sep 28, 2019

fabiocos commented Sep 29, 2019

cmsbuild commented Sep 29, 2019 • edited

cmsbuild commented Sep 29, 2019

cmsbuild commented Sep 29, 2019

cmsbuild commented Sep 29, 2019

ianna commented Sep 30, 2019

cmsbuild commented Sep 30, 2019

fabiocos commented Oct 1, 2019

cmsbuild commented Sep 22, 2019 •

edited

cmsbuild commented Sep 29, 2019 •

edited