Migrate EcalDeadChannelRecoveryBDTG to GBRForest #28040
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28040/11972
|
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: RecoLocalCalo/EcalDeadChannelRecoveryAlgos @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
Hi
I am not sure what this message means. Somebody else is migrating the
software or else ?
Thanks
Nancy
…On 21/09/19 12:27, perrotta wrote:
@nancymarinelli @taroni FYI
--
________________________________________
Nancy Marinelli
Research Associate Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940
|
|
Changes observed in the number of conversion photons in Phase2 wf 11634.0 are spurious ones. As I did never notice it before the last couple of days, something should have been merged since then which oririginates such a non-reproducibility in this Phase2 workflow (in all three cases it is the same wf) |
|
please test |
|
The tests are being triggered in jenkins. |
|
Just reopening this PR to check in. After all there is still a corresponding issue #27648 open. |
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
comparison-available
tests-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28040/20398
|
|
please test |
|
@thomreis since this PR has been momentarily re-opened for technical reasons, let me profit to inquire with you about the status of the validation of the EcalDeadChannelRecovery: are there updates since last July (bi-annual check, see #28040 (comment))? |
|
… On 15/12/20 10:07, perrotta wrote:
@thomreis since this PR has been momentarily re-opened for technical reasons, let me profit to inquire with you about the status of the validation of the EcalDeadChannelRecovery: are there updates since last July (bi-annual check, see #28040 (comment))?
--
________________________________________
Nancy Marinelli
Research Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940
|
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-55d22b/11658/summary.html Comparison SummarySummary:
|
|
@perrotta to my knowledge there are no updates to the validation status. At least I do not find any related presentation in ECAL meetings of the last half year. |
|
@Couderc, @pierazzini
the valitadation from the MET group started some while ago, but it's now
stopped because the person who was taking care of it is no longer
available for health reasons. So we are waiting for a replacement.
Bottom line, no news. The PR stays as it is
Nancy
…On 23/12/20 18:04, Thomas Reis wrote:
@perrotta to my knowledge there are no updates to the validation status. At least I do not find any related presentation in ECAL meetings of the last half year.
--
________________________________________
Nancy Marinelli
Research Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940
|
|
Thank you @thomreis and @nancymarinelli |
|
Meanwhile we have had some discussion with the JME group about the validation and they did not see any issue popping out (though the first results were not encouraging, it was due to a bug I believe). I am adding JME conveners (@lathomas @ahinzmann ) to confirm that the validation is ok on their side. Sorry for the late notice. Cheers Fabrice & Simone |
|
(adding @kirschen ) |
|
Hello
here 3 talks. In link 3 there are more references.
1)
https://indico.cern.ch/event/830302/contributions/3477927/attachments/1871241/3079254/DeadChannelSummary_RecoMeeting.pdf
2)
https://indico.cern.ch/event/817347/contributions/3412127/attachments/1841036/3018464/DeadChannelSummary.pdf
3)
https://indico.cern.ch/event/824161/contributions/3446656/attachments/1855556/3047564/DeadChannelCMSSW_June2019.pdf
Nancy
…On 04/01/21 09:23, lathomas wrote:
(adding @kirschen )
Hello,
I can confirm we didn't see any issue, but also no improvement, including for electrons, which sounds a bit surprising. Could someone point us to an ECAL/EGM study showing the expected effect?
Thanks !
--
________________________________________
Nancy Marinelli
Research Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940
|
PR description:
I don't know what the plans are to resolve #27648, but as I already wrote the code for the migration to find out if it would be possible and compared the output with TMVA (see #27175 (comment)), I thought I might as well do a PR with the code from back then.
PR validation:
CMSSW compiles, local matrix tests pass. However, I'm not sure if the comparisons would catch possible problems. Is the channel recovery now enabled by default so the matrix tests would capture possible differences? That would make validating this PR easier.
if this PR is a backport please specify the original PR:
No backport intended.