Restore Disabled PCA inputs for deepTau v2 (10_6_X)

[fabiocos]

PR description:

Restore #27882, revert #28032, add fix proposed in #28041 for the failures observed in the IB

PR validation:

See #28041 by @mbluj
Successfully tested with runTheMatrix.py -l 1325.51,1329.1,136.772,136.8521 -i all --ibeos

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_10_6_X.

It involves the following packages:

Configuration/Eras
Configuration/StandardSequences
PhysicsTools/NanoAOD
PhysicsTools/PatAlgos
RecoTauTag/RecoTau

@perrotta, @kpedro88, @peruzzim, @cmsbuild, @franzoni, @fgolf, @slava77, @santocch, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @felicepantaleo, @emilbols, @Martin-Grunewald, @ahinzmann, @peruzzim, @seemasharmafnal, @mmarionncern, @makortel, @smoortga, @acaudron, @dgulhan, @jdolen, @ferencek, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @clelange, @HeinerTholen, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @andrzejnovak, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Disabled PCA inputs for deepTau v2 #27878

[fabiocos]

please test workflow 1325.51,1329.1,136.772,136.8521

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2608/console Started: 2019/09/21 19:48

[cmsbuild]

+1
Tested at: 7dcc316
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02795c/2608/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02795c/2608/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 44 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3210949
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3210613
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.047 KiB( 32 files compared)
• DQMHistoSizes: changed ( 1325.7 ): 0.047 KiB Physics/NanoAODDQM
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[perrotta]

backport of #27878

[perrotta]

+1

• This is the same as Disabled PCA inputs for deepTau v2 #27878, but the v2p1 is only activated by the Run2_2016 and Run2_2018 modifiers; Run2_2017, Run_3, Phase2 remain unchanged
• Jenkins tests show differences in tau ID on miniAOD only in 2016 and 2018, as expected
• The latest commit included was apparently effective in fixing the issue observed with workflows 1325.51,1329.1,136.772,136.8521

[santocch]

+1

[srimanob]

@peruzzim Could you please have a look? Thanks.

[peruzzim]

I have tested it for the default configurations without modifiers, and it looks ok

[peruzzim]

+xpog

[fabiocos]

+operations

no change in the main configuration part

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[peruzzim]

@mbluj are we sure this is correct? We are asking for the deepTau bit also in cases where it is not there, e.g. UL2017, and it will crash there, right? I can fix it with the nanoAOD PR, could you please confirm?

[mbluj]

DeepTauID 2017v2 is contained in MiniAOD of UL2017 as it is now, i.e. w/o planned reMiniAOD, so check for tauID('byVVVLooseDeepTau2017v2VSjet') is correct.
What concerns planned UL2018/2016 and UL2017 reMiniAOD it will contain DeepTauID 2017v2p1 so this check is modified to tauID('byVVVLooseDeepTau2017v2p1VSjet') with corresponding era modifiers.
Regardless, I think that matrix tests will fail in case of inconsistent configurations of Mini and NanoAOD.

[peruzzim]

ok, sorry, I did not read carefully enough and I thought we were asking for 2p1