Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastsim tracking add dedx collection - backport to 102X #28085

Merged

Conversation

ssekmen
Copy link
Contributor

@ssekmen ssekmen commented Sep 28, 2019

backport of #25512

Modified code in FastSimulation/SimplifiedParticlePropagator/ package to make de/dx collections. This involved adding the plugin FastTrackDeDxProducer.cc and modifying FastTrackerRecHits.[.h, .cc], as well as adding a data member to the class DataFormats/TrackerRecHit2D/interface/FastTrackerRecHit.h called energyLoss.

This PR was backported earlier, but closed afterwards as it was not urgently needed for production. Now it is urgently needed for a large SUSY signal production. PPD has also been notified.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 28, 2019

A new Pull Request was created by @ssekmen (Sezen Sekmen) for CMSSW_10_2_X.

It involves the following packages:

DataFormats/TrackerRecHit2D
FastSimulation/SimplifiedGeometryPropagator
FastSimulation/TrackingRecHitProducer

@perrotta, @ssekmen, @lveldere, @sbein, @civanch, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @matt-komm, @gpetruc, @rovere, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ssekmen ssekmen changed the title Fastsim tracking add dedx collection 102 x Fastsim tracking add dedx collection - backport to 102X Sep 28, 2019
@ssekmen
Copy link
Contributor Author

ssekmen commented Sep 28, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 28, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2714/console Started: 2019/09/28 12:43

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c3b8ed/2714/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007468
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007276
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@ssekmen
Copy link
Contributor Author

ssekmen commented Sep 28, 2019

+1

@perrotta
Copy link
Contributor

+1

  • Identical to Fastsim tracking add dedx collection #25512, merged in master since CMSSW_10_5_0_pre1
  • For reco, this PR just adds dedx to the FastTrackerRecHit data format; that class (as well as its derived ones) only enters in FastSim related stuffs
  • Jenkins tests pass and show no (relevant) differences

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

@ssekmen please have a look at the "Duplicate Dictionaries" errors in the tests results. There are a few related to FastSim: they don't seem to be originated by this PR, but I assume it can be something you want to look at.

@ssekmen
Copy link
Contributor Author

ssekmen commented Sep 29, 2019

Thanks for pointing out @Perrota . We will take a look. @sbein , FYI.

@sbein
Copy link
Contributor

sbein commented Sep 29, 2019

+1

1 similar comment
@fabiocos
Copy link
Contributor

fabiocos commented Oct 8, 2019

+1

@cmsbuild cmsbuild merged commit fb46680 into cms-sw:CMSSW_10_2_X Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants