New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fastsim tracking add dedx collection - backport to 102X #28085
Fastsim tracking add dedx collection - backport to 102X #28085
Conversation
A new Pull Request was created by @ssekmen (Sezen Sekmen) for CMSSW_10_2_X. It involves the following packages: DataFormats/TrackerRecHit2D @perrotta, @ssekmen, @lveldere, @sbein, @civanch, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@ssekmen please have a look at the "Duplicate Dictionaries" errors in the tests results. There are a few related to FastSim: they don't seem to be originated by this PR, but I assume it can be something you want to look at. |
+1 |
1 similar comment
+1 |
backport of #25512
Modified code in FastSimulation/SimplifiedParticlePropagator/ package to make de/dx collections. This involved adding the plugin FastTrackDeDxProducer.cc and modifying FastTrackerRecHits.[.h, .cc], as well as adding a data member to the class DataFormats/TrackerRecHit2D/interface/FastTrackerRecHit.h called energyLoss.
This PR was backported earlier, but closed afterwards as it was not urgently needed for production. Now it is urgently needed for a large SUSY signal production. PPD has also been notified.