Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx222 Correct some of the cfg files and make file naming more homogeneous #28086

Merged
merged 2 commits into from Oct 4, 2019

Conversation

bsunanda
Copy link
Contributor

PR description:

Correct the cfg files so that the dump geometries are visible in firework. Also try to have similar file names of the dumped files

PR validation:

Tested privately using the cfg files in the test area

if this PR is a backport please specify the original PR:

Nothing special

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28086/12066

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 29, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2715/console Started: 2019/09/29 10:55

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da9b78/2715/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2958092
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2957750
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@kpedro88
Copy link
Contributor

+upgrade

@bsunanda
Copy link
Contributor Author

bsunanda commented Oct 1, 2019

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28086/12090

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2735/console Started: 2019/10/01 15:17

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2019

Pull request #28086 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da9b78/2735/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2958092
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2957749
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@ianna
Copy link
Contributor

ianna commented Oct 1, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Oct 4, 2019

@kpedro88 this looks quite technical and ok to me, I see you already approved it at the first round, so I will integrated it

@fabiocos
Copy link
Contributor

fabiocos commented Oct 4, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Oct 4, 2019

merge

@cmsbuild cmsbuild merged commit 9a4af56 into cms-sw:master Oct 4, 2019
@kpedro88
Copy link
Contributor

kpedro88 commented Oct 7, 2019

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants