Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of CTPPS sequences #28090

Merged
merged 1 commit into from Oct 4, 2019
Merged

Conversation

fioriNTU
Copy link
Contributor

PR description:

This PR is part of the DQM sequence cleanup effort. It move an Harvesting module to step 2, originally it was included in a step 1,

PR validation:

Used runTheMatrix with 10024 workflow, and validated the Online client manually on top of the latest available 11_0_X IB.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@fioriNTU
Copy link
Contributor Author

@fabferro @forthommel FYI

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28090/12077

@fioriNTU
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 30, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2724/console Started: 2019/09/30 12:35

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fioriNTU for master.

It involves the following packages:

DQM/CTPPS
DQM/Integration
DQMOffline/Configuration

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@forthommel, @jan-kaspar, @threus, @batinkov, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jan-kaspar
Copy link
Contributor

Thanks @fioriNTU , it looks good to me!

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce7237/2724/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2958092
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2957750
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@fioriNTU
Copy link
Contributor Author

+1
comparison looks as expected, no plots added or deleted

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Oct 4, 2019

+1

@cmsbuild cmsbuild merged commit 4528839 into cms-sw:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants