Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD4hep: Add access to vectors in SecPars from DDFilteredView #28108

Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Oct 2, 2019

PR description:

  • Add an easier access to vectors by names of the SpecPar and its attribute
  • Specialize the accessor for std::vector<std::string> and std::vector<double>

Example:

std::vector<double> result = fview.get<std::vector<double>>("hf", "LongFL");

or

std::vector<std::string> result = fview.get<std::vector<std::string>>("hf", "LongFL");

@bsunanda - FYI

PR validation:

DDFilteredView.cppunit.cc runs automatically. It compares the hard-coded expected reference values with the actually retrieved from xml for hf SpecPar and attl and LongFL attributes.

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28108/12112

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2019

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@vargasa this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ianna
Copy link
Contributor Author

ianna commented Oct 2, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2758/console Started: 2019/10/02 17:18
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2766/console Started: 2019/10/02 22:50

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43ae76/2766/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2956833
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2956491
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@ianna
Copy link
Contributor Author

ianna commented Oct 3, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Oct 5, 2019

+1

the updated test configurations appear to run smoothly

@cmsbuild cmsbuild merged commit 04ed620 into cms-sw:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants