Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mayConsumes in VolumeBasedMagneticFieldESProducerFromDB #28120

Merged
merged 6 commits into from Oct 20, 2019
Merged

Use mayConsumes in VolumeBasedMagneticFieldESProducerFromDB #28120

merged 6 commits into from Oct 20, 2019

Commits on Oct 7, 2019

  1. Added RunInfoTestESProducer used for testing 

    This also included a test for RunInfoTestESProducer.
    @Dr15Jones
    Dr15Jones committed Oct 7, 2019
    Copy the full SHA
    7d2432c View commit details
    Browse the repository at this point in the history

  2. Added MagFieldConfigTestESProducer 

    This is used to test VolumeBasedMagneticFieldESProducerFromDB.
    @Dr15Jones
    Dr15Jones committed Oct 7, 2019
    Copy the full SHA
    e7c3558 View commit details
    Browse the repository at this point in the history

  3. Use mayConsumes in VolumeBasedMagneticFieldESProducerFromDB 

    The module decides which geometry to read from the database by
reading the value stored in the MagFieldConfig EventSetup object.
The decision cannot be made at module configuration time, only at
run time. Therefore mayConsumes must be used.

Unit tests were added to guarantee the module's behavior is the
same after this change.
    @Dr15Jones
    Dr15Jones committed Oct 7, 2019
    Copy the full SHA
    5106105 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2019

  1. Removed unit tests from MagneticField/GeomBuilder

    @Dr15Jones
    Dr15Jones committed Oct 10, 2019
    Copy the full SHA
    24ae889 View commit details
    Browse the repository at this point in the history

  2. Removed unused runInfo_ member data

    @Dr15Jones
    Dr15Jones committed Oct 10, 2019
    Copy the full SHA
    87b508e View commit details
    Browse the repository at this point in the history

  3. Added back LogInfo messages to VolumeBasedMagneticFieldESProducerFromDB

    @Dr15Jones
    Dr15Jones committed Oct 10, 2019
    Copy the full SHA
    9d98541 View commit details
    Browse the repository at this point in the history