Add tau pog tags to GTs #28134

tocheng · 2019-10-09T10:01:54Z

PR description:

The PR is to PR 28063 support tau ID at nanoAOD level. 75 labeled tags are added to data/MC tags to support tau ID calculation.
No effect on physics performance is expect when testing this PR alone.

GT diffs:
Data offline GTs
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_v8/110X_dataRun2_v7
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_relval_v8/110X_dataRun2_relval_v7

Data prompt-like GTs
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_PromptLike_v7/110X_dataRun2_PromptLike_v6
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_PromptLike_HEfail_v7/110X_dataRun2_PromptLike_HEfail_v8
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_PromptLike_HI_v7/110X_dataRun2_PromptLike_HI_v6

Run-1 MC GTs
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun1_design_v2/110X_mcRun1_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun1_realistic_v2/110X_mcRun1_realistic_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun1_HeavyIon_v2/110X_mcRun1_HeavyIon_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun1_pA_v2/110X_mcRun1_pA_v1

2015 MC GTs
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun2_startup_v2/110X_mcRun2_startup_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun2_asymptotic_l1stage1_v2/110X_mcRun2_asymptotic_l1stage1_v1

2016 MC GTs
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun2_design_v3/110X_mcRun2_design_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun2_asymptotic_v3/110X_mcRun2_asymptotic_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun2_HeavyIon_v2/110X_mcRun2_HeavyIon_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun2_pA_v3/110X_mcRun2_pA_v2

2017 MC GTs
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mc2017_design_v2/110X_mc2017_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mc2017_realistic_v2/110X_mc2017_realistic_v1

2018 MC GTs
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018_design_v2/110X_upgrade2018_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018_realistic_v6/110X_upgrade2018_realistic_v5
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018_realistic_HI_v5/110X_upgrade2018_realistic_HI_v4

Run 3 MC GTs
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2021_design_v4/110X_mcRun3_2021_design_v3
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2021_realistic_v4/110X_mcRun3_2021_realistic_v3
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2023_realistic_v4/110X_mcRun3_2023_realistic_v3
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2024_realistic_v4/110X_mcRun3_2024_realistic_v3

Run 4 MC GTs
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun4_realistic_v2/110X_mcRun4_realistic_v1

PR validation:

See the description above for the physics validation of the tags.

In addition, a technical test was performed: runTheMatrix.py -l limited -i all --ibeos

PR validation:

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2019-10-09T10:02:42Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-10-09T10:10:31Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28134/12182

This PR adds an extra 12KB to repository

cmsbuild · 2019-10-09T10:11:01Z

A new Pull Request was created by @tocheng (Tongguang) for master.

It involves the following packages:

Configuration/AlCa

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

tocheng · 2019-10-09T10:17:05Z

@cmsbuild please test

cmsbuild · 2019-10-09T10:17:29Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2846/console Started: 2019/10/09 12:18

cmsbuild · 2019-10-09T12:35:09Z

+1
Tested at: 16a85d8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e7989/2846/summary.html

cmsbuild · 2019-10-09T12:35:11Z

Comparison job queued.

cmsbuild · 2019-10-09T13:43:51Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #28063
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2850/console Started: 2019/10/09 15:44

cmsbuild · 2019-10-09T14:58:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e7989/2846/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2961052
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2960707
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

cmsbuild · 2019-10-09T15:52:45Z

-1

Tested at: 16a85d8

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1874cc/2850/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
1330.0 step5

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15/step5_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15.log

158.0 step3

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/step3_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO.log

10042.0 step6

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step6_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

25202.0 step5

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step5_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

10024.0 step6

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step6_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

10824.0 step6

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step6_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

10224.0 step5

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU/step5_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU.log

tocheng · 2019-10-16T16:04:20Z

@fabiocos I rebased the commit to the lastest IB 2019-10-15-2300 yesterday. And now there is a unit test error due to alignment which should not be relevant to this PR. Do you have any suggestions? Thanks.

cmsbuild · 2019-10-16T16:18:16Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e7989/2981/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2961064
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2960719
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

christopheralanwest · 2019-10-16T16:20:07Z

please test with #28063

cmsbuild · 2019-10-16T16:20:49Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #28063
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2995/console Started: 2019/10/16 21:59

cmsbuild · 2019-10-16T21:57:38Z

+1
Tested at: a022761
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca9ac3/2995/summary.html

cmsbuild · 2019-10-16T21:57:45Z

Comparison job queued.

cmsbuild · 2019-10-17T00:21:54Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca9ac3/2995/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 2448 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2961064
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2960718
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

christopheralanwest · 2019-10-17T22:25:14Z

+1

cmsbuild · 2019-10-17T22:25:44Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-10-18T11:52:09Z

@tocheng @christopheralanwest I understand that #28063 is dependent on this PR, but is the opposite true? Do I understand correctly that in this PR new tags are added? And why do we see changes in old run1 tests? What does change in conditions for this old runs?

tocheng · 2019-10-18T11:59:01Z

@fabiocos I don't think this PR depends on #28063 .
The change in run1 is because the deprecated MVA IDs are removed.
See the comments in the PR:
#28063 (comment)

fabiocos · 2019-10-18T20:05:28Z

+1

cmsbuild added this to the CMSSW_11_0_X milestone Oct 9, 2019

cmsbuild added alca-pending code-checks-pending comparison-pending orp-pending pending-signatures tests-pending labels Oct 9, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 9, 2019

tocheng changed the title ~~Add tau pog tags~~ Add tau pog tags to GTs Oct 9, 2019

cmsbuild added tests-started and removed tests-pending labels Oct 9, 2019

tocheng mentioned this pull request Oct 9, 2019

Subject main tau ID payloads to global tag control #28063

Merged

cmsbuild added tests-approved and removed tests-started labels Oct 9, 2019

cmsbuild added requires-external tests-started and removed tests-approved labels Oct 9, 2019

cmsbuild added comparison-available and removed comparison-pending labels Oct 9, 2019

cmsbuild added tests-pending requires-external tests-started and removed tests-rejected tests-pending labels Oct 16, 2019

cmsbuild added tests-approved and removed tests-started labels Oct 16, 2019

cmsbuild added comparison-available and removed comparison-pending labels Oct 17, 2019

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Oct 17, 2019

cmsbuild added orp-approved and removed orp-pending labels Oct 18, 2019

cmsbuild merged commit e44272a into cms-sw:master Oct 18, 2019

This was referenced Feb 26, 2020

Add 11_0_X prompt global tag for Run 3 data #29050

Merged

Add 11_0_X prompt global tag for Run 3 data [11_0_X] #29051

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tau pog tags to GTs #28134

Add tau pog tags to GTs #28134

tocheng commented Oct 9, 2019 •

edited

cmsbuild commented Oct 9, 2019

cmsbuild commented Oct 9, 2019

cmsbuild commented Oct 9, 2019

tocheng commented Oct 9, 2019

cmsbuild commented Oct 9, 2019 •

edited

cmsbuild commented Oct 9, 2019

cmsbuild commented Oct 9, 2019

cmsbuild commented Oct 9, 2019 •

edited

cmsbuild commented Oct 9, 2019

cmsbuild commented Oct 9, 2019

tocheng commented Oct 16, 2019

cmsbuild commented Oct 16, 2019

christopheralanwest commented Oct 16, 2019

cmsbuild commented Oct 16, 2019 •

edited

cmsbuild commented Oct 16, 2019

cmsbuild commented Oct 16, 2019

cmsbuild commented Oct 17, 2019

christopheralanwest commented Oct 17, 2019

cmsbuild commented Oct 17, 2019

fabiocos commented Oct 18, 2019

tocheng commented Oct 18, 2019

fabiocos commented Oct 18, 2019

Add tau pog tags to GTs #28134

Add tau pog tags to GTs #28134

Conversation

tocheng commented Oct 9, 2019 • edited

PR description:

PR validation:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Oct 9, 2019

cmsbuild commented Oct 9, 2019

cmsbuild commented Oct 9, 2019

tocheng commented Oct 9, 2019

cmsbuild commented Oct 9, 2019 • edited

cmsbuild commented Oct 9, 2019

cmsbuild commented Oct 9, 2019

cmsbuild commented Oct 9, 2019 • edited

cmsbuild commented Oct 9, 2019

cmsbuild commented Oct 9, 2019

tocheng commented Oct 16, 2019

cmsbuild commented Oct 16, 2019

christopheralanwest commented Oct 16, 2019

cmsbuild commented Oct 16, 2019 • edited

cmsbuild commented Oct 16, 2019

cmsbuild commented Oct 16, 2019

cmsbuild commented Oct 17, 2019

christopheralanwest commented Oct 17, 2019

cmsbuild commented Oct 17, 2019

fabiocos commented Oct 18, 2019

tocheng commented Oct 18, 2019

fabiocos commented Oct 18, 2019

tocheng commented Oct 9, 2019 •

edited

cmsbuild commented Oct 9, 2019 •

edited

cmsbuild commented Oct 9, 2019 •

edited

cmsbuild commented Oct 16, 2019 •

edited