Muon FSR recovery for miniaod and nanoaod [102X]

[peruzzim]

backport #28118

Rebase of #28118 on the 10_2_X branch
@arizzi @gpetruc

[cmsbuild]

A new Pull Request was created by @peruzzim for CMSSW_10_2_X.

It involves the following packages:

DataFormats/PatCandidates
MuonAnalysis/MuonAssociators

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@gouskos, @calderona, @abbiendi, @jhgoh, @bellan, @HuguesBrun, @rovere, @hatakeyamak, @gpetruc, @battibass, @trocino, @folguera, @cbernet this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Muon FSR recovery for miniaod and nanoaod  #28118

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2856/console Started: 2019/10/09 20:43

[cmsbuild]

+1
Tested at: 6e0eaad
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fd709/2856/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fd709/2856/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007468
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3007277
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[cmsbuild]

Pull request #28135 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

[peruzzim]

added backport of #28221, I'm going to do a joint re-test with #28145

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) #28145,#28095
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3051/console Started: 2019/10/21 14:27

[cmsbuild]

+1
Tested at: 5e271e9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3c6d3/3051/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3c6d3/3051/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 163 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007468
• DQMHistoTests: Total failures: 39
• DQMHistoTests: Total nulls: 3
• DQMHistoTests: Total successes: 3007236
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 7.903 KiB( 30 files compared)
• DQMHistoSizes: changed ( 1325.7 ): 7.903 KiB Physics/NanoAODDQM
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[peruzzim]

@perrotta @slava77 could you please add back your signature as #28221 has been backported here? Thanks

[slava77]

+1

for #28135 5e271e9

• updated to include a commit already added to the master in Fix electron PFCandidates RefVector usage in MuonFSRProducer #28221
• jenkins tests pass; the changes only in nanoAOD, thery are due to other PRs also included in the tests

[fabiocos]

+1

[fabiocos]

merge

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will be automatically merged.