Migrate SiPixelGenErrorDBObjectESProducer and SiPixelTemplateDBObjectESProducer to EventSetup consumes

[makortel]

PR description:

This PR is an updated version of #27043 to migrate SiPixelGenErrorDBObjectESProducer and SiPixelTemplateDBObjectESProducer to EventSetup consumes (as part of #26748) using the recently-introduced "mayConsume" functionality.

PR validation:

Code compiles, limited matrix runs.

@Dr15Jones

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28142/12188

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

CalibTracker/SiPixelESProducers

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @dkotlins, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2855/console Started: 2019/10/09 19:58

[makortel]

I couldn't avoid noticing that the two files are almost exact copies differing only with the product and record types. The copy paste could be easily avoided with templates. If the DPG likes, I can do that.

[cmsbuild]

+1
Tested at: b6b48ea
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9aa232/2855/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9aa232/2855/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2961056
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2960714
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[fabiocos]

@mmusich I believe the comment #28142 (comment) by @makortel is for you

@christopheralanwest @pohsun could you please check the PR?

[mmusich]

@fabiocos, @makortel, if I have to cast my vote, I would prefer to keep things like they are, for the sake of intuition of what each producer is actually doing (at the cost of a slight code duplication).
Maybe @tsusa or @pmaksim1 have different opinions and can voice them.

[tlampen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[makortel]

@fabiocos, @makortel, if I have to cast my vote, I would prefer to keep things like they are, for the sake of intuition of what each producer is actually doing (at the cost of a slight code duplication).
Maybe @tsusa or @pmaksim1 have different opinions and can voice them.

Ok, that's fine.

[fabiocos]

+1