-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Implementation of ProducesCollector #28154
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28154/12208
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: EventFilter/L1TRawToDigi @perrotta, @smuzaffar, @benkrikler, @Dr15Jones, @lveldere, @civanch, @sbein, @ssekmen, @mdhildreth, @Martin-Grunewald, @rekovic, @cmsbuild, @kpedro88, @slava77, @fwyzard, @santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test This should not change the results of any output. |
The tests are being triggered in jenkins. |
Comparison job queued. |
5 reviewers approved but still waiting for 3 on this PR. This one is a really simple technical software change. It creates a ProducesCollector analogous to the ConsumesCollector so |
code-checks |
The code-checks are being triggered in jenkins. |
+1 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28154/12535
|
In my test there is no real merge conflict with #28214 so the integration of this PR may move forward seamlessly |
+1 |
@civanch please have a look, the implementation looks coherent with all the other areas as far as I can understand. I plan to integrate this PR in next IB tonight |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Initial implementation of the ProducesCollector. The ProducerBase::produces function is now a protected member of ProducerBase. When produces needs to be called in a helper class (outside the module constructor), the ProducesCollector must be used. This PR also migrates all the code in the repository to work with this change. It does not affect modules that call produces directly inside their constructor. The purpose is to reduce the number of things that depend on ProducerBase. Helper classes used by modules no longer need to depend on it.
PR validation:
Includes a new unit test for the ProducesCollector class.