Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tau Validation/DQM: switching deepTau version from v2 to v2p1 for CMSSW10_6_X #28177

Merged

Conversation

aspiezia
Copy link
Contributor

PR description:

This is a backport of #28176
The pull request is intendend to update the deepTau ID from the v2 version to the new v2p1 version.
@rmanzoni @roger-wolf

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aspiezia for CMSSW_10_6_X.

It involves the following packages:

Validation/RecoTau

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #28177 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2955/console Started: 2019/10/15 17:13

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f4bfc/2955/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211969
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211634
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.656 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 27434.0,... ): 0.006 KiB RecoTauV/miniAODValidationZTT
  • DQMHistoSizes: changed ( 27434.0,... ): 0.006 KiB RecoTauV/miniAODValidationQCD
  • DQMHistoSizes: changed ( 27434.0,... ): 0.006 KiB RecoTauV/miniAODValidationRealData
  • DQMHistoSizes: changed ( 27434.0,... ): 0.006 KiB RecoTauV/miniAODValidationZMM
  • DQMHistoSizes: changed ( 27434.0,... ): 0.006 KiB RecoTauV/miniAODValidationZEE
  • DQMHistoSizes: changed ( 27434.0,... ): 0.006 KiB RecoTauV/miniAODValidationRealMuonsData
  • DQMHistoSizes: changed ( 27434.0,... ): 0.006 KiB RecoTauV/miniAODValidationRealElectronsData
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@peruzzim peruzzim mentioned this pull request Oct 23, 2019
5 tasks
@aspiezia aspiezia changed the title switching deepTau version from v2 to v2p1 for CMSSW10_6_X Tau Validation/DQM: switching deepTau version from v2 to v2p1 for CMSSW10_6_X Oct 28, 2019
@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6c542cb into cms-sw:CMSSW_10_6_X Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants