Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sim consumes migration fixes #2818

Merged

Conversation

mdhildreth
Copy link
Contributor

Collection of consumes migration fixes for many of the SIM-responsible packages. Passes simple runTheMatrix testing.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mdhildreth for CMSSW_7_1_X.

Sim consumes migration fixes

It involves the following packages:

EventFilter/CastorRawToDigi
EventFilter/DTRawToDigi
EventFilter/ESDigiToRaw
EventFilter/EcalDigiToRaw
EventFilter/RPCRawToDigi
SimGeneral/PileupInformation
SimMuon/MCTruth

@civanch, @thspeer, @emeschi, @mdhildreth, @cmsbuild, @anton-a, @nclopezo, @slava77, @mommsen, @Degano can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented Mar 12, 2014

+1

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

@ktf - suggest we bypass daq signature here - none of these changes are for them

@ktf
Copy link
Contributor

ktf commented Mar 19, 2014

Ok, but this does not merge. @mdhildreth can you rebase?

@mdhildreth
Copy link
Contributor Author

Dropped Castor changes due to conflict. Merge is successful now.

@cmsbuild
Copy link
Contributor

Pull request #2818 was updated. @civanch, @thspeer, @emeschi, @mdhildreth, @cmsbuild, @anton-a, @nclopezo, @slava77, @mommsen, @Degano can you please check and sign again.

@mdhildreth
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Mar 23, 2014
@davidlange6 davidlange6 merged commit 96a6918 into cms-sw:CMSSW_7_1_X Mar 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants