fix case of enums to match db

[davidlange6]

PR description:

Fixes unit test failures introduced in #28157

PR validation:

Affected unit tests now work

[cmsbuild]

The code-checks are being triggered in jenkins.

[smuzaffar]

please test
@fabiocos , this seems to fix the unit tests, so I would suggest to merge it for 11h00 (even if PR tests do not finish) or we can delay the 11h Ib for an hour.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28186/12274

• This PR adds an extra 20KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2971/console Started: 2019/10/16 10:16

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

CondCore/Utilities

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

@davidlange6 @smuzaffar so I keep my revert commit https://github.com/fabiocos/cmssw/tree/fc-revert28157 on hold, assuming this further fix can take care of all the issues.

[davidlange6]

would have been better to have merged this for 1100... it can't really do harm.

…

On Oct 16, 2019, at 10:21 AM, Fabio Cossutti ***@***.***> wrote: @davidlange6 @smuzaffar so I keep my revert commit https://github.com/fabiocos/cmssw/tree/fc-revert28157 on hold, assuming this further fix can take care of all the issues. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[fabiocos]

@davidlange6 I agreed with @smuzaffar to hold the IB for a little, he is running a set of tests, then we will merge and have an IB just for this

[smuzaffar]

I have tested locally and not all the unit tests passed [a] but it is much better now. I would suggest to merge it before 12h and start IB

[a]

---> test EcalTPGPhysicsConst_O2O_test had ERRORS
---> test EcalTPGFineGrainEBIdMap_O2O_test succeeded
---> test EcalDAQ_O2O_test had ERRORS
---> test EcalTPGWeightIdMap_O2O_test succeeded
---> test EcalTPGLutIdMap_O2O_test succeeded
---> test EcalTPGPedestals_O2O_test succeeded
---> test EcalDCS_O2O_test succeeded
---> test EcalADCToGeV_update_test succeeded
---> test EcalIntercalibConstants_O2O_test had ERRORS
---> test EcalLaser_O2O_test had ERRORS
---> test EcalTPGFineGrainEBGroup_O2O_test succeeded
---> test EcalTPGFineGrainTowerEE_O2O_test succeeded
---> test EcalTPGFineGrainStripEE_O2O_test succeeded
---> test EcalTPGSpike_O2O_test succeeded
---> test EcalTPGLutGroup_O2O_test succeeded
---> test testPngHistograms succeeded
---> test EcalTPGTowerStatus_O2O_test succeeded
---> test testHistograms succeeded
---> test testBasicPayload succeeded
---> test test_CreateFileLists had ERRORS
---> test EcalTPGCrystalStatus_O2O_test succeeded
---> test EcalTPGSlidingWindow_O2O_test succeeded
---> test EcalTPGWeightGroup_O2O_test succeeded
---> test EcalTPGLinearizationConst_O2O_test succeeded
---> test test_PrepareInputDb succeeded
---> test EcalTPGBadStripStatus_O2O_test succeeded
---> test SiStripDCS_O2O_test had ERRORS
---> test RunInfoStart_O2O_test succeeded
---> test test_MpsWorkFlow succeeded
---> test SiStripDAQ_O2O_test succeeded

      6 ERRORS
     24 succeeded

[fabiocos]

@smuzaffar I agree, it does not look as the final solution, but it definitely improves the situation

[fabiocos]

+1

[fabiocos]

merge

[smuzaffar]

@fabiocos you want to merge any thing else or should I start the IB now.

[cmsbuild]

+1
Tested at: 9b6698a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc8032/2971/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc8032/2971/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2961064
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2960722
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files