Fix stall grapher x axis label. #28206
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28206/12315
|
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: FWCore/Concurrency @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test Nothing actually runs this code in any test... |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
I’d rather have the values converted to seconds |
|
Comparison is ready Comparison Summary:
|
|
@wddgit do you plan to further update the PR following the advice #28206 (comment) by @Dr15Jones ? |
|
Yes. I'll probably submit a new update today. I keep getting side tracked on other things... |
Fix bug in stall grapher utility. Was plotting microseconds, but x axis labels said seconds. Make it plot seconds. Also add new command arguments to set the x axis lower and upper limits. This should not affect anything other than the plots in the PDF file created by the stall grapher.
wddgit
force-pushed
the
fixStallGraphAxisLabel
branch
from
0d1eef8
to
acc0cb0
Compare
|
The code-checks are being triggered in jenkins. |
cmsbuild
added
code-checks-pending
comparison-pending
tests-pending
and removed
tests-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28206/12568
|
|
Pull request #28206 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Since some recent changes, the stall grapher has been plotting
milliseconds not seconds (the x axis label says seconds). Make it
really plot seconds. Also add new command line arguments to
explicitly set the x axis limits in the stall grapher.
PR validation:
Nothing runs this Python script in the release or unit/RelVal tests. The
change has no effect other than on the plots in the PDF file produced
by the stall grapher.