Fix dependencies and includes for FWCore and DataFormats #28219

oshadura · 2019-10-20T15:04:23Z

PR description:

Enable C++ modules for FWCore and FWCore (small fixes in dependencies and header includes)
cc: @vgvassilev @davidlange6 @smuzaffar

cmsbuild · 2019-10-20T15:04:56Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-10-20T15:14:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28219/12345

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/CTPPSReco/BuildFile.xml modified in PR(s): add missing dependencies in DataFormats BuildFiles #28209
- File DataFormats/EgammaTrackReco/BuildFile.xml modified in PR(s): add missing dependencies in DataFormats BuildFiles #28209
- File DataFormats/L1TrackTrigger/BuildFile.xml modified in PR(s): add missing dependencies in DataFormats BuildFiles #28209

cmsbuild · 2019-10-20T15:14:56Z

A new Pull Request was created by @oshadura (Oksana Shadura) for master.

It involves the following packages:

DataFormats/CTPPSReco
DataFormats/Candidate
DataFormats/EgammaTrackReco
DataFormats/HLTReco
DataFormats/HeavyIonEvent
DataFormats/L1TrackTrigger
DataFormats/TauReco

@perrotta, @cmsbuild, @benkrikler, @fwyzard, @kpedro88, @Martin-Grunewald, @rekovic, @slava77, @santocch can you please review it and eventually sign? Thanks.
@yslai, @forthommel, @jan-kaspar, @sviret, @rovere, @gpetruc, @mandrenguyen, @yetkinyilmaz this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2019-10-20T16:00:03Z

DataFormats/HLTReco/interface/TriggerEvent.h

@@ -17,6 +17,7 @@
 #include "DataFormats/Common/interface/traits.h"
 #include <string>
 #include <vector>
+#include <assert.h>


Suggested change

#include <assert.h>

#include <cassert>

Thank you! it is fixed!

Dr15Jones · 2019-10-20T16:00:47Z

DataFormats/HLTReco/interface/HLTPerformanceInfo.h

@@ -4,6 +4,7 @@

 #include <string>
 #include <vector>
+#include <assert.h>


Suggested change

#include <assert.h>

#include <cassert>

Thank you! it is fixed!

Dr15Jones · 2019-10-20T16:01:54Z

The pull request title doesn't seem to match what was changed.

cmsbuild · 2019-10-21T09:15:17Z

The code-checks are being triggered in jenkins.

oshadura · 2019-10-21T09:17:32Z

The pull request title doesn't seem to match what was changed.
You are right, I changed it (this PR is part of cms-sw/cmsdist#5284)

cmsbuild · 2019-10-21T09:21:44Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28219/12352

This PR adds an extra 24KB to repository
Found files with invalid states:
- MagneticField/GeomBuilder/test/python/testMagneticFieldDB_parameterized_cfg.py:
  - Added: 12e01e3
  - Deleted: 273811c
- MagneticField/GeomBuilder/test/testMagneticFieldDB_cfg.results:
  - Added: 12e01e3
  - Deleted: 273811c
- MagneticField/GeomBuilder/test/testMagneticFieldDB_valueOverride_cfg.results:
  - Added: 12e01e3
  - Deleted: 273811c
- MagneticField/GeomBuilder/test/python/testMagneticFieldDB_cfg.py:
  - Added: 12e01e3
  - Deleted: 273811c
- MagneticField/GeomBuilder/test/testMagneticFieldDB_parameterized_cfg.results:
  - Added: 12e01e3
  - Deleted: 273811c
- MagneticField/GeomBuilder/test/python/testMagneticFieldDB_valueOverride_cfg.py:
  - Added: 12e01e3
  - Deleted: 273811c
- MagneticField/GeomBuilder/test/testMagneticFieldDB.sh:
  - Added: 12e01e3
  - Deleted: 273811c
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/CTPPSReco/BuildFile.xml modified in PR(s): add missing dependencies in DataFormats BuildFiles #28209
- File DataFormats/EgammaTrackReco/BuildFile.xml modified in PR(s): add missing dependencies in DataFormats BuildFiles #28209
- File DataFormats/L1TrackTrigger/BuildFile.xml modified in PR(s): add missing dependencies in DataFormats BuildFiles #28209

cmsbuild · 2019-10-21T09:22:15Z

Pull request #28219 was updated. @perrotta, @cmsbuild, @benkrikler, @Dr15Jones, @cvuosalo, @civanch, @tlampen, @christopheralanwest, @ianna, @mdhildreth, @Martin-Grunewald, @rekovic, @franzoni, @tocheng, @slava77, @ggovi, @fwyzard, @pohsun, @santocch, @kpedro88 can you please check and sign again.

…idates)

cmsbuild · 2019-10-21T09:36:19Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-10-21T09:43:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28219/12353

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/CTPPSReco/BuildFile.xml modified in PR(s): add missing dependencies in DataFormats BuildFiles #28209
- File DataFormats/EgammaTrackReco/BuildFile.xml modified in PR(s): add missing dependencies in DataFormats BuildFiles #28209
- File DataFormats/L1TrackTrigger/BuildFile.xml modified in PR(s): add missing dependencies in DataFormats BuildFiles #28209

cmsbuild · 2019-10-21T09:43:40Z

Pull request #28219 was updated. @perrotta, @cmsbuild, @benkrikler, @fwyzard, @kpedro88, @Martin-Grunewald, @rekovic, @slava77, @santocch can you please check and sign again.

perrotta · 2019-10-21T09:44:01Z

please test

cmsbuild · 2019-10-21T09:44:11Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3046/console Started: 2019/10/21 12:24

davidlange6 · 2019-10-21T12:00:30Z

@oshadura and i agreed to use #28209 and #28222 instead of this PR.

cmsbuild · 2019-10-21T13:54:59Z

+1
Tested at: 13cc6f7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-295398/3046/summary.html

cmsbuild · 2019-10-21T13:55:02Z

Comparison job queued.

cmsbuild · 2019-10-21T16:01:22Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-295398/3046/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2961064
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2960722
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

cmsbuild added this to the CMSSW_11_0_X milestone Oct 20, 2019

cmsbuild added analysis-pending code-checks-pending comparison-pending hlt-pending l1-pending orp-pending pending-signatures reconstruction-pending tests-pending upgrade-pending labels Oct 20, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 20, 2019

Dr15Jones suggested changes Oct 20, 2019

View reviewed changes

oshadura force-pushed the cxxmodules-part1 branch from 26be4c3 to f0e914f Compare October 21, 2019 09:14

cmsbuild added alca-pending code-checks-pending db-pending geometry-pending and removed code-checks-approved labels Oct 21, 2019

oshadura changed the title ~~Enable C++ modules for FWCore and FWCore~~ Fix dependencies and includes for FWCore and DataFormats Oct 21, 2019

cmsbuild removed the code-checks-pending label Oct 21, 2019

oshadura added 3 commits October 21, 2019 11:33

Fix missing dependencies for DataFormats

6e96c2c

Add mising includes in DataFormats

b4307a9

Remove not used headers (it introduces cyclic dependency with PatCand…

13cc6f7

…idates)

oshadura force-pushed the cxxmodules-part1 branch from f0e914f to 13cc6f7 Compare October 21, 2019 09:35

cmsbuild added code-checks-pending reconstruction-pending and removed alca-pending code-checks-approved db-pending geometry-pending reconstruction-rejected labels Oct 21, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 21, 2019

cmsbuild added tests-started and removed tests-pending labels Oct 21, 2019

davidlange6 mentioned this pull request Oct 21, 2019

a few missing includes/dependencies in DataFormats #28222

Merged

davidlange6 closed this Oct 21, 2019

cmsbuild added tests-approved and removed tests-started labels Oct 21, 2019

cmsbuild added comparison-available and removed comparison-pending labels Oct 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix dependencies and includes for FWCore and DataFormats #28219

Fix dependencies and includes for FWCore and DataFormats #28219

oshadura commented Oct 20, 2019

cmsbuild commented Oct 20, 2019

cmsbuild commented Oct 20, 2019

cmsbuild commented Oct 20, 2019

Dr15Jones Oct 20, 2019

oshadura Oct 21, 2019

Dr15Jones Oct 20, 2019

oshadura Oct 21, 2019

Dr15Jones commented Oct 20, 2019

cmsbuild commented Oct 21, 2019

oshadura commented Oct 21, 2019

cmsbuild commented Oct 21, 2019

cmsbuild commented Oct 21, 2019

cmsbuild commented Oct 21, 2019

cmsbuild commented Oct 21, 2019

cmsbuild commented Oct 21, 2019

perrotta commented Oct 21, 2019

cmsbuild commented Oct 21, 2019 •

edited

davidlange6 commented Oct 21, 2019

cmsbuild commented Oct 21, 2019

cmsbuild commented Oct 21, 2019

cmsbuild commented Oct 21, 2019

Fix dependencies and includes for FWCore and DataFormats #28219

Fix dependencies and includes for FWCore and DataFormats #28219

Conversation

oshadura commented Oct 20, 2019

PR description:

cmsbuild commented Oct 20, 2019

cmsbuild commented Oct 20, 2019

cmsbuild commented Oct 20, 2019

Dr15Jones Oct 20, 2019

Choose a reason for hiding this comment

oshadura Oct 21, 2019

Choose a reason for hiding this comment

Dr15Jones Oct 20, 2019

Choose a reason for hiding this comment

oshadura Oct 21, 2019

Choose a reason for hiding this comment

Dr15Jones commented Oct 20, 2019

cmsbuild commented Oct 21, 2019

oshadura commented Oct 21, 2019

cmsbuild commented Oct 21, 2019

cmsbuild commented Oct 21, 2019

cmsbuild commented Oct 21, 2019

cmsbuild commented Oct 21, 2019

cmsbuild commented Oct 21, 2019

perrotta commented Oct 21, 2019

cmsbuild commented Oct 21, 2019 • edited

davidlange6 commented Oct 21, 2019

cmsbuild commented Oct 21, 2019

cmsbuild commented Oct 21, 2019

cmsbuild commented Oct 21, 2019

cmsbuild commented Oct 21, 2019 •

edited