Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to incorporate the non-perfect crossing angle compensation #2822

Merged
merged 2 commits into from Mar 13, 2014

Conversation

davidlange6
Copy link
Contributor

Pull requesting for Anders who has git technical problems

Fixes to the hourglass beam spot given discussions between Anders and Stephane Farthouk - expected luminous region is now 4.4 cm.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 for CMSSW_6_2_X_SLHC.

Changes to incorporate the non-perfect crossing angle compensation

It involves the following packages:

IOMC/EventVertexGenerators

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

merge

Tested along with #2809.
Tests 10000, 10200, 10400, 11200, 11400, 11600, 11800, 12000, 12800 and 13000 pass all steps.
Tests 12200, 12400, 12600, 13200 and 13400 fail in step 2 with known errors.

@cmsbuild
Copy link
Contributor

Pull request #2822 was updated. @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please check and sign again.

cmsbuild added a commit that referenced this pull request Mar 13, 2014
Changes to incorporate the non-perfect crossing angle compensation
@cmsbuild cmsbuild merged commit 44d8928 into cms-sw:CMSSW_6_2_X_SLHC Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants