HCAL Run3-related updates for HLT #28233

Martin-Grunewald · 2019-10-22T12:50:57Z

PR description:

HCAL Run3-related updates for HLT
Based on CMSSW_11_0_0_pre10
Importing the customisation as given in #28163 directly into ConfDB & the HLT menus.

PR validation:

TSG tests

if this PR is a backport please specify the original PR:

N/A

cmsbuild · 2019-10-22T12:51:31Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-10-22T12:57:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28233/12378

This PR adds an extra 820KB to repository

cmsbuild · 2019-10-22T12:59:51Z

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @geoff-smith this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2019-10-22T14:03:59Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-10-22T14:10:08Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28233/12382

This PR adds an extra 936KB to repository

cmsbuild · 2019-10-22T14:10:39Z

Pull request #28233 was updated. @Martin-Grunewald, @cmsbuild, @fwyzard can you please check and sign again.

Martin-Grunewald · 2019-10-22T14:35:48Z

please test

cmsbuild · 2019-10-22T14:36:15Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3094/console Started: 2019/10/22 16:36

cmsbuild · 2019-10-22T16:14:07Z

+1
Tested at: 7dd3611
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2b031b/3094/summary.html

cmsbuild · 2019-10-22T16:14:10Z

Comparison job queued.

cmsbuild · 2019-10-22T18:07:31Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2b031b/3094/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2960950
DQMHistoTests: Total failures: 3866
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2956743
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.112 KiB( 33 files compared)
DQMHistoSizes: changed ( 12434.0,... ): 0.056 KiB HLT/GeneralHLTOffline
Checked 147 log files, 16 edm output root files, 34 DQM output files

cmsbuild · 2019-10-29T11:20:16Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-10-29T11:26:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28233/12501

This PR adds an extra 1308KB to repository

cmsbuild · 2019-10-29T11:26:32Z

Pull request #28233 was updated. @Martin-Grunewald, @cmsbuild, @fwyzard can you please check and sign again.

Martin-Grunewald · 2019-10-29T13:38:18Z

please test

cmsbuild · 2019-10-29T13:38:48Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3221/console Started: 2019/10/29 14:39

cmsbuild · 2019-10-29T15:05:40Z

+1
Tested at: bd0a74b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2b031b/3221/summary.html

cmsbuild · 2019-10-29T15:05:43Z

Comparison job queued.

cmsbuild · 2019-10-29T16:51:53Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2b031b/3221/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2960922
DQMHistoTests: Total failures: 3866
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2956715
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.112 KiB( 33 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 0.056 KiB HLT/GeneralHLTOffline
Checked 147 log files, 16 edm output root files, 34 DQM output files

Martin-Grunewald · 2019-10-30T10:39:35Z

+1

cmsbuild · 2019-10-30T10:40:14Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-10-30T13:39:13Z

Configuration/HLT/python/autoCondHLT.py

@@ -19,6 +19,7 @@
    'Fake1'        : ( ','.join( [ 'L1Menu_Collisions2015_25nsStage1_v5'                     , l1MenuRecord,connectionString, l1MenuLabel, "2015-10-26 12:00:00.000"] ), ),
    'Fake2'        : ( ','.join( [ 'L1Menu_Collisions2016_v9_m2_xml'                         ,l1tMenuRecord,connectionString,l1tMenuLabel, "2016-10-06 19:36:53.000"] ), ),
    'FULL'         : ( ','.join( [ 'L1Menu_Collisions2018_v2_1_0-d1_xml'                     ,l1tMenuRecord,connectionString,l1tMenuLabel, "2018-08-14 11:03:08.000"] ), ),
+    '2018'         : ( ','.join( [ 'L1Menu_Collisions2018_v2_1_0-d1_xml'                     ,l1tMenuRecord,connectionString,l1tMenuLabel, "2018-08-14 11:03:08.000"] ), ),


@Martin-Grunewald could you please clarify the use of this 2018 that is a clone of FULL as far as I can see?

2018 is a clone of GRun BEFORE the introduction of the Hcal Run3 changes in GRun and the other development menus, corresponding to 2018 Hcal. The plan is to have it for TSG studies in 11_0 and remove it in 11_1.

@Martin-Grunewald to keep GRun free for further changes I guess

Indeed: GRun is for development toward Run-3.

fabiocos · 2019-10-30T20:13:45Z

+1

CMSHLT-2091 HCAL Run3-related updates

978fa06

cmsbuild added this to the CMSSW_11_0_X milestone Oct 22, 2019

cmsbuild added code-checks-pending comparison-pending hlt-pending orp-pending pending-signatures tests-pending labels Oct 22, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 22, 2019

Bug fix in parameter type

7dd3611

cmsbuild added code-checks-pending and removed code-checks-approved labels Oct 22, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 22, 2019

cmsbuild added tests-started and removed tests-pending labels Oct 22, 2019

cmsbuild added tests-approved and removed tests-started labels Oct 22, 2019

cmsbuild added the code-checks-pending label Oct 29, 2019

cmsbuild removed the code-checks-pending label Oct 29, 2019

cmsbuild added the code-checks-approved label Oct 29, 2019

cmsbuild added tests-started and removed tests-pending labels Oct 29, 2019

cmsbuild added tests-approved and removed tests-started labels Oct 29, 2019

cmsbuild added comparison-available and removed comparison-pending labels Oct 29, 2019

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Oct 30, 2019

fabiocos reviewed Oct 30, 2019

View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels Oct 30, 2019

cmsbuild merged commit 9514494 into cms-sw:master Oct 30, 2019

fabiocos mentioned this pull request Nov 3, 2019

HBHE: HLT Run3 configuration #28163

Merged

Martin-Grunewald deleted the HLThcalRun3updates110X branch October 27, 2021 07:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HCAL Run3-related updates for HLT #28233

HCAL Run3-related updates for HLT #28233

Martin-Grunewald commented Oct 22, 2019 •

edited

cmsbuild commented Oct 22, 2019

cmsbuild commented Oct 22, 2019

cmsbuild commented Oct 22, 2019

cmsbuild commented Oct 22, 2019

cmsbuild commented Oct 22, 2019

cmsbuild commented Oct 22, 2019

Martin-Grunewald commented Oct 22, 2019

cmsbuild commented Oct 22, 2019 •

edited

cmsbuild commented Oct 22, 2019

cmsbuild commented Oct 22, 2019

cmsbuild commented Oct 22, 2019

cmsbuild commented Oct 29, 2019

cmsbuild commented Oct 29, 2019

cmsbuild commented Oct 29, 2019

Martin-Grunewald commented Oct 29, 2019

cmsbuild commented Oct 29, 2019 •

edited

cmsbuild commented Oct 29, 2019

cmsbuild commented Oct 29, 2019

cmsbuild commented Oct 29, 2019

Martin-Grunewald commented Oct 30, 2019

cmsbuild commented Oct 30, 2019

fabiocos Oct 30, 2019

Martin-Grunewald Oct 30, 2019

fabiocos Oct 30, 2019

Martin-Grunewald Oct 30, 2019

fabiocos commented Oct 30, 2019

HCAL Run3-related updates for HLT #28233

HCAL Run3-related updates for HLT #28233

Conversation

Martin-Grunewald commented Oct 22, 2019 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Oct 22, 2019

cmsbuild commented Oct 22, 2019

cmsbuild commented Oct 22, 2019

cmsbuild commented Oct 22, 2019

cmsbuild commented Oct 22, 2019

cmsbuild commented Oct 22, 2019

Martin-Grunewald commented Oct 22, 2019

cmsbuild commented Oct 22, 2019 • edited

cmsbuild commented Oct 22, 2019

cmsbuild commented Oct 22, 2019

cmsbuild commented Oct 22, 2019

cmsbuild commented Oct 29, 2019

cmsbuild commented Oct 29, 2019

cmsbuild commented Oct 29, 2019

Martin-Grunewald commented Oct 29, 2019

cmsbuild commented Oct 29, 2019 • edited

cmsbuild commented Oct 29, 2019

cmsbuild commented Oct 29, 2019

cmsbuild commented Oct 29, 2019

Martin-Grunewald commented Oct 30, 2019

cmsbuild commented Oct 30, 2019

fabiocos Oct 30, 2019

Choose a reason for hiding this comment

Martin-Grunewald Oct 30, 2019

Choose a reason for hiding this comment

fabiocos Oct 30, 2019

Choose a reason for hiding this comment

Martin-Grunewald Oct 30, 2019

Choose a reason for hiding this comment

fabiocos commented Oct 30, 2019

Martin-Grunewald commented Oct 22, 2019 •

edited

cmsbuild commented Oct 22, 2019 •

edited

cmsbuild commented Oct 29, 2019 •

edited