Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BuildFile in plugin directory RecoMuon/MuonIdentification #2824

Merged
merged 1 commit into from Mar 13, 2014
Merged

Fix BuildFile in plugin directory RecoMuon/MuonIdentification #2824

merged 1 commit into from Mar 13, 2014

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Mar 12, 2014

This is to fix

----- Begin Fatal Exception 10-Mar-2014 00:24:11 CET-----------------------
An exception of category 'MultiplePlugins' occurred while
   [0] Constructing the EventProcessor
Exception Message:
The plugin 'ME0SegmentMatcher' is found in multiple files 
 '"pluginRecoMuonMuonIdentificationPlugins.so"'
 '"pluginTestMuonMuonIdentificationPlugins.so"'
in directory '/tmp/grimes/CMSSW_6_2_X_SLHC_2014-03-07-0200/lib/slc5_amd64_gcc472'.
The code must be changed so the plugin only appears in one plugin file. You will need to remove the macro which registers the plugin so it only appears in one of these files.
  If none of these files register such a plugin, then the problem originates in a library to which all these files link.
The plugin registration must be removed from that library since plugins are not allowed in regular libraries.
----- End Fatal Exception -------------------------------------------------

@dildick
Copy link
Contributor Author

dildick commented Mar 12, 2014

I just tested it on upgrade workflow 13000. Seems to run fine:

13000_FourMuPt1_200+FourMuPt_1_200_Extended2023Muon_GenSimFull+DigiFull_Extended2023Muon+RecoFull_Extended2023Muon+HARVESTFull_Extended2023Muon Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED - time date Wed Mar 12 12:02:29 2014-date Wed Mar 12 11:53:48 2014; exit: 0 0 0 0
1 1 1 1 tests passed, 0 0 0 0 failed

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_6_2_X_SLHC.

Fix BuildFile in plugin directory RecoMuon/MuonIdentification

It involves the following packages:

RecoMuon/MuonIdentification

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

merge

Not sure how previous testing failed to catch the error. Tests 130xx fixed with this pull request. Tested the normal set of tests too.

cmsbuild added a commit that referenced this pull request Mar 13, 2014
Fix BuildFile in plugin directory RecoMuon/MuonIdentification
@cmsbuild cmsbuild merged commit aad246b into cms-sw:CMSSW_6_2_X_SLHC Mar 13, 2014
@dildick dildick deleted the bugfix-recomuon-muonidentification branch March 13, 2014 09:01
@dildick
Copy link
Contributor Author

dildick commented Mar 13, 2014

Indeed, it is very strange that in #2782, test 13000 passed, but 13200 and 13400 failed. Anyway, there all fixed now.

@mark-grimes
Copy link

Really? 13200 (Extended2023CFCal) and 13400 (Extended2023CFCal4Eta) have never worked beyond GEN-SIM.

The error in 13000 has returned in CMSSW_6_2_X_SLHC_2014-03-13-0200. Simply recompiling RecoMuon/MuonIdentification fixes it however. No idea why, I've asked the build team.

scram project CMSSW_6_2_X_SLHC_2014-03-13-0200
cd CMSSW_6_2_X_SLHC_2014-03-13-0200/src
cmsenv
runTheMatrix.py -w upgrade -l 13000

Test fails.

rm -rf ./*    # Remove all the files from the tests
git-cms-addpkg RecoMuon/MuonIdentification
scram b -j 10
runTheMatrix.py -w upgrade -l 13000

Test passes. Very strange.

@dildick
Copy link
Contributor Author

dildick commented Mar 13, 2014

Very strange indeed. I would expect 13000 to work in the new build.

@davidlange6
Copy link
Contributor

all - please move the plugins in the src directory into the plugins directory. All will be better.

On Mar 13, 2014, at 4:22 PM, Sven Dildick notifications@github.com
wrote:

Very strange indeed. I would expect 13000 to work in the new build.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants