Include dedx collections in fastsim output

[kpedro88]

PR description:

The FastTrackDeDxProducer is now included in the FastSim reconstruction sequence with two versions (strip tracker and pixel).

The sizes of the new output collections from a test config are (using edmEventSize):

Branch Name | Average Uncompressed Size (Bytes/Event) | Average Compressed Size (Bytes/Event) 
recoDeDxDataedmValueMap_dedxHarmonic2__RECO. 11165.7 1507.67
recoDeDxDataedmValueMap_dedxPixelHarmonic2__RECO. 11192.3 1399.33

Similar collections are already included in regular RECO/AOD output, so this should be an acceptable increase for FastSim RECO/AOD output.

This PR also fixes a condition in the producer that was modified in the backport PR #28235, but erroneously not modified in master.

PR validation:

Ran a private test config without errors and observed the desired collections in the output.

attn: @sbein @ssekmen @scarletnorberg

[cmsbuild]

The code-checks are being triggered in jenkins.

[kpedro88]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28257/12417

• This PR adds an extra 20KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3137/console Started: 2019/10/24 17:27

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

FastSimulation/SimplifiedGeometryPropagator
RecoTracker/Configuration
RecoTracker/DeDx

@perrotta, @ssekmen, @lveldere, @sbein, @civanch, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @matt-komm, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

How about the following?

fastSim.toReplaceWith(trackingGlobalRecoTask, cms.Task(doAlldEdXEstimators, trackExtrapolator))

[kpedro88]

It actually needs to be doAlldEdXEstimatorsTask since sequences can't be added to tasks

[makortel]

To me doFastdEdXEstimators Sequence looks redundant as the necessary replacement is done already with doFastdEdXEstimatorsTask (which could be further simplified to

fastSim.toReplaceWith(doAlldEdXEstimatorsTask, cms.Task(dedxHarmonic2, dedxPixelHarmonic2))

)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28257/12426

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #28257 was updated. @perrotta, @ssekmen, @lveldere, @sbein, @civanch, @mdhildreth, @cmsbuild, @slava77 can you please check and sign again.

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3143/console Started: 2019/10/24 19:13

[cmsbuild]

+1
Tested at: 3ffdf28
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-456a5f/3143/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-456a5f/3143/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2961036
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2960694
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[sbein]

+1

[perrotta]

+1

• Changes in the reco configs only refer to fastsim customizations
• Jenkins tests pass and show no changes in reco outputs

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1