-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topythia8183 62 x #2829
Topythia8183 62 x #2829
Conversation
To be made together with the corresponding change of cmsdist |
A new Pull Request was created by @mkirsano for CMSSW_6_2_X. Topythia8183 62 x It involves the following packages: GeneratorInterface/Pythia8Interface @vciulli, @nclopezo, @thuer, @cmsbuild, @bendavid, @Degano can you please review it and eventually sign? Thanks. |
+1 |
I added this commit to the same pull request on request of Josh, he hopes that 6_2_X will converge faster like this. |
This is a backport of the slha code from 7_1_X |
I will actually run this through some tests with lhe files from amc@nlo, which should also explicitly test the slha functionality. |
-1 /afs/cern.ch/work/b/bendavid/CMSSWgen2/CMSSW_6_2_7_patch2/src/GeneratorInterface/LHEInterface/plugins/Pythia8Hadronisation.cc:14:20: fatal error: Pythia.h: No such file or directory |
This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X IBs unless changes or unless it breaks tests. @Degano can you please take care of it? |
-1 >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/LHEInterface/src/JetMatching.cc >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/LHEInterface/src/LHEEvent.cc >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/LHEInterface/src/JetClustering.cc >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/LHEInterface/src/JetMatchingMLM.cc In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/Pythia8Interface/src/RandomP8.cc:1:0: /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/Pythia8Interface/interface/RandomP8.h:1:28: fatal error: Pythia8/Pythia.h: No such file or directory compilation terminated. In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/Pythia8Interface/src/RandomP8.cc:1:0: /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/Pythia8Interface/interface/RandomP8.h:1:28: fatal error: Pythia8/Pythia.h: No such file or directory compilation terminated. gmake: **\* [tmp/slc6_amd64_gcc472/src/GeneratorInterface/Pythia8Interface/src/GeneratorInterfacePythia8Interface/RandomP8.o] Error 1 you can see the results of the tests here: |
This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X IBs unless changes (but tests are reportedly failing). @Degano can you please take care of it? |
Hello, this happens if it is not synchronized with the change of On 03/19/2014 11:11 AM, cmsbuild wrote:
|
Yes, sorry, I am re-running the tests with external PR right now. |
OK, but the priority now is 5_3_X On 03/19/2014 11:33 AM, Alessandro Degano wrote:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X IBs unless changes (tests are also fine). @Degano can you please take care of it? |
@mkirsano: the new 6_2_X is going to be built next week, while 5_3_X is the week after so please try to go ahead first with the backporting in 6_2_X (this is equally important than the one to 5_3_X) |
I tested it also against the slc6 cmsdist PR cms-sw/cmsdist#508 and everything works fine there too. |
+1 |
Generator fixes -- Topythia8183 62 x
No description provided.