Topythia8183 62 x #2829

mkirsano · 2014-03-12T19:46:01Z

No description provided.

mkirsano · 2014-03-12T19:47:43Z

To be made together with the corresponding change of cmsdist

cmsbuild · 2014-03-12T19:48:23Z

A new Pull Request was created by @mkirsano for CMSSW_6_2_X.

Topythia8183 62 x

It involves the following packages:

GeneratorInterface/Pythia8Interface

@vciulli, @nclopezo, @thuer, @cmsbuild, @bendavid, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

ghost · 2014-03-13T11:02:38Z

+1
Tested locally alongside with cmsdist PR: cms-sw/cmsdist#497 with the usual runTheMatrix workflows, that is 401.0,1306.0,101.0,1003.0,50101.0.
All the tests passed.

mkirsano · 2014-03-13T21:03:31Z

I added this commit to the same pull request on request of Josh, he hopes that 6_2_X will converge faster like this.

mkirsano · 2014-03-13T21:04:26Z

This is a backport of the slha code from 7_1_X

cmsbuild · 2014-03-13T21:08:20Z

Pull request #2829 was updated. @vciulli, @nclopezo, @thuer, @cmsbuild, @bendavid, @Degano can you please check and sign again.

bendavid · 2014-03-13T21:17:37Z

I will actually run this through some tests with lhe files from amc@nlo, which should also explicitly test the slha functionality.

bendavid · 2014-03-14T13:35:34Z

-1
I think you missed the include changes in LHEInterface (dependent package which you get with git-cms-checkdeps -a for example)

/afs/cern.ch/work/b/bendavid/CMSSWgen2/CMSSW_6_2_7_patch2/src/GeneratorInterface/LHEInterface/plugins/Pythia8Hadronisation.cc:14:20: fatal error: Pythia.h: No such file or directory
compilation terminated.
gmake: *** [tmp/slc5_amd64_gcc472/src/GeneratorInterface/LHEInterface/plugins/GeneratorInterfacePythia8Hadronisation/Pythia8Hadronisation.o] Error 1
gmake: *** Waiting for unfinished jobs....
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2014-03-14T15:23:20Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X IBs unless changes or unless it breaks tests. @Degano can you please take care of it?

cmsbuild · 2014-03-19T10:11:39Z

-1
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/LHEInterface/src/JetMatching.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/LHEInterface/src/LHEEvent.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/LHEInterface/src/JetClustering.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/LHEInterface/src/JetMatchingMLM.cc 
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/Pythia8Interface/src/RandomP8.cc:1:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/Pythia8Interface/interface/RandomP8.h:1:28: fatal error: Pythia8/Pythia.h: No such file or directory
compilation terminated.
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/Pythia8Interface/src/RandomP8.cc:1:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/Pythia8Interface/interface/RandomP8.h:1:28: fatal error: Pythia8/Pythia.h: No such file or directory
compilation terminated.
gmake: **\* [tmp/slc6_amd64_gcc472/src/GeneratorInterface/Pythia8Interface/src/GeneratorInterfacePythia8Interface/RandomP8.o] Error 1

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2829/53/summary.html

cmsbuild · 2014-03-19T10:13:25Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X IBs unless changes (but tests are reportedly failing). @Degano can you please take care of it?

mkirsano · 2014-03-19T10:19:42Z

Hello, this happens if it is not synchronized with the change of
pythia8 version in cmsdist.

On 03/19/2014 11:11 AM, cmsbuild wrote:

-1
I found an error when building:

Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/LHEInterface/src/JetMatching.cc

Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/LHEInterface/src/LHEEvent.cc

Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/LHEInterface/src/JetClustering.cc

Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/LHEInterface/src/JetMatchingMLM.cc

In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/Pythia8Interface/src/RandomP8.cc:1:0:

/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/Pythia8Interface/interface/RandomP8.h:1:28: fatal error: Pythia8/Pythia.h: No such file or directory

compilation terminated.

In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/Pythia8Interface/src/RandomP8.cc:1:0:

/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X-slc6_amd64_gcc472/CMSSW_6_2_X_2014-03-19-0200/src/GeneratorInterface/Pythia8Interface/interface/RandomP8.h:1:28: fatal error: Pythia8/Pythia.h: No such file or directory

compilation terminated.

gmake: *** [tmp/slc6_amd64_gcc472/src/GeneratorInterface/Pythia8Interface/src/GeneratorInterfacePythia8Interface/RandomP8.o] Error 1

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2829/53/summary.html

—
Reply to this email directly or view it on GitHub
#2829 (comment).

ghost · 2014-03-19T10:33:22Z

Yes, sorry, I am re-running the tests with external PR right now.
Could you also please make a PR for Pythia 8.183 in cmsdist for the branch 6_2_X/devel_gcc472 which is the branch used for slc6 that does not merges from 6_2_X/stable?

mkirsano · 2014-03-19T10:41:07Z

OK, but the priority now is 5_3_X

On 03/19/2014 11:33 AM, Alessandro Degano wrote:

Yes, sorry, I am re-running the tests with external PR right now.
Could you also please make a PR for Pythia 8.183 in cmsdist for the
branch 6_2_X/devel_gcc472 which is the branch used for slc6 that does
not merges from 6_2_X/stable?

—
Reply to this email directly or view it on GitHub
#2829 (comment).

ghost · 2014-03-19T10:53:22Z

+1
Tested locally.

cmsbuild · 2014-03-19T10:53:34Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X IBs unless changes (tests are also fine). @Degano can you please take care of it?

vciulli · 2014-03-19T10:54:25Z

@mkirsano: the new 6_2_X is going to be built next week, while 5_3_X is the week after so please try to go ahead first with the backporting in 6_2_X (this is equally important than the one to 5_3_X)

ghost · 2014-03-21T09:08:59Z

I tested it also against the slc6 cmsdist PR cms-sw/cmsdist#508 and everything works fine there too.

davidlange6 · 2014-03-21T12:58:21Z

+1

Generator fixes -- Topythia8183 62 x

mkirsano added 6 commits March 12, 2014 20:36

to pythia8 183

0b494f5

to pythia8 183

bf19174

to pythia8 183

71e1d63

to pythia8 183

99bd9e3

to pythia8 183

d526849

to pythia8 183

19f5c1d

mkirsano added generators-pending labels Mar 12, 2014

mkirsano added generators-pending labels Mar 13, 2014

slha file manipulation

9cd4efc

mkirsano added generators-pending labels Mar 13, 2014

mkirsano added generators-rejected labels Mar 14, 2014

mkirsano added fully-signed labels Mar 14, 2014

mkirsano added fully-signed labels Mar 19, 2014

mkirsano added fully-signed labels Mar 21, 2014

ghost pushed a commit that referenced this pull request Mar 21, 2014

Merge pull request #2829 from mkirsano/topythia8183_62X

ca5158b

Generator fixes -- Topythia8183 62 x

ghost merged commit ca5158b into cms-sw:CMSSW_6_2_X Mar 21, 2014

ghost mentioned this pull request Mar 24, 2014

Fix headers path for new Pythia 8.183. #2991

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Topythia8183 62 x #2829

Topythia8183 62 x #2829

mkirsano commented Mar 12, 2014

mkirsano commented Mar 12, 2014

cmsbuild commented Mar 12, 2014

ghost commented Mar 13, 2014

mkirsano commented Mar 13, 2014

mkirsano commented Mar 13, 2014

cmsbuild commented Mar 13, 2014

bendavid commented Mar 13, 2014

bendavid commented Mar 14, 2014

cmsbuild commented Mar 14, 2014

cmsbuild commented Mar 19, 2014

cmsbuild commented Mar 19, 2014

mkirsano commented Mar 19, 2014

ghost commented Mar 19, 2014

mkirsano commented Mar 19, 2014

ghost commented Mar 19, 2014

cmsbuild commented Mar 19, 2014

vciulli commented Mar 19, 2014

ghost commented Mar 21, 2014

davidlange6 commented Mar 21, 2014

Topythia8183 62 x #2829

Topythia8183 62 x #2829

Conversation

mkirsano commented Mar 12, 2014

mkirsano commented Mar 12, 2014

cmsbuild commented Mar 12, 2014

ghost commented Mar 13, 2014

mkirsano commented Mar 13, 2014

mkirsano commented Mar 13, 2014

cmsbuild commented Mar 13, 2014

bendavid commented Mar 13, 2014

bendavid commented Mar 14, 2014

cmsbuild commented Mar 14, 2014

cmsbuild commented Mar 19, 2014

cmsbuild commented Mar 19, 2014

mkirsano commented Mar 19, 2014

ghost commented Mar 19, 2014

mkirsano commented Mar 19, 2014

ghost commented Mar 19, 2014

cmsbuild commented Mar 19, 2014

vciulli commented Mar 19, 2014

ghost commented Mar 21, 2014

davidlange6 commented Mar 21, 2014