Modernized MTDDetLayerGeometryESProducer

[Dr15Jones]

PR description:

• consolidated into 1 file
• added consumes and fillDescriptions
• moved classes only used by this module into plugins/

PR validation:

The code compiles. This is mostly a technical restructuring which should have no effect on the results.

[cmsbuild]

The code-checks are being triggered in jenkins.

[Dr15Jones]

This is needed by #28223

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28319/12562

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

RecoMTD/DetLayers

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3276/console Started: 2019/10/30 19:11

[cmsbuild]

+1
Tested at: aec330b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab6d3e/3276/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab6d3e/3276/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2961036
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2960694
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[perrotta]

+1

• Technical: no functional changes to the code
• Jenkins tests pass

[kpedro88]

@lgray @pmeridian @fabiocos FYI

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

no visible effect on MTD as expected in tests