New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a sequence for DQMMessageLogger and use it in autoDQM #28325
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28325/12575
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: DQMOffline/Configuration @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 134.71,136.868 |
The tests are being triggered in jenkins. |
-1 Tested at: 79898bf You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following workflows: runTheMatrix-results/136.868_RunZeroBias2018B+RunZeroBias2018B+HLTDR2_2018+RECODR2_2018reHLT_ZBOffline+HARVEST2018ZB/step4_RunZeroBias2018B+RunZeroBias2018B+HLTDR2_2018+RECODR2_2018reHLT_ZBOffline+HARVEST2018ZB.log |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
please test workflow 134.812,134.912,136.732,136.745,136.756,136.767,136.778,136.789,136.801,136.813,136.88 |
The tests are being triggered in jenkins. |
The tests are being triggered in jenkins. |
@smuzaffar @jfernan2 this fix unveils another issue in the HARVESTING step that needs to be addressed separately. I will integrate for the time being this PR as anyway it fixes part of the crashes. |
+1 |
merge |
from the message in the HARVESTING step even when not crashing I see this fix is incorrect there:
so this needs to be further adjusted |
this problem seems simply solved by replacing |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@jfernan2 ok, I think the source of the problem is the revision of the SiStrip |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This PR adds in
DQMOffline
a sequence for theDQMMessgaeLogger
module and uses it inautoDQM
. This solves the failures observed for ZeroBias samples in CMSSW_11_0_X_2019-10-30-2300 , based on the diagnosis and suggestiopn by @Dr15Jones https://github.com/cms-sw/cmssw/pull/28156/files#r341171685 .PR validation:
Test wf 134.71 passes