Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sequence for DQMMessageLogger and use it in autoDQM #28325

Merged
merged 1 commit into from Nov 1, 2019

Conversation

fabiocos
Copy link
Contributor

PR description:

This PR adds in DQMOffline a sequence for the DQMMessgaeLogger module and uses it in autoDQM. This solves the failures observed for ZeroBias samples in CMSSW_11_0_X_2019-10-30-2300 , based on the diagnosis and suggestiopn by @Dr15Jones https://github.com/cms-sw/cmssw/pull/28156/files#r341171685 .

PR validation:

Test wf 134.71 passes

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28325/12575

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

DQMOffline/Configuration

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test workflow 134.71,136.868

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3287/console Started: 2019/10/31 17:08

@cmsbuild
Copy link
Contributor

-1

Tested at: 79898bf

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f8fe4d/3287/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
136.868 step4

runTheMatrix-results/136.868_RunZeroBias2018B+RunZeroBias2018B+HLTDR2_2018+RECODR2_2018reHLT_ZBOffline+HARVEST2018ZB/step4_RunZeroBias2018B+RunZeroBias2018B+HLTDR2_2018+RECODR2_2018reHLT_ZBOffline+HARVEST2018ZB.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@fabiocos
Copy link
Contributor Author

please test workflow 134.812,134.912,136.732,136.745,136.756,136.767,136.778,136.789,136.801,136.813,136.88

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3291/console Started: 2019/10/31 23:27

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3293/console Started: 2019/11/01 10:28

@fabiocos
Copy link
Contributor Author

fabiocos commented Nov 1, 2019

@smuzaffar @jfernan2 this fix unveils another issue in the HARVESTING step that needs to be addressed separately. I will integrate for the time being this PR as anyway it fixes part of the crashes.
Please comment for possible further updates

@fabiocos
Copy link
Contributor Author

fabiocos commented Nov 1, 2019

+1

@fabiocos
Copy link
Contributor Author

fabiocos commented Nov 1, 2019

merge

@cmsbuild cmsbuild merged commit db478bd into cms-sw:master Nov 1, 2019
@fabiocos
Copy link
Contributor Author

fabiocos commented Nov 1, 2019

from the message in the HARVESTING step even when not crashing I see this fix is incorrect there:

Step: HARVESTING Spec: ['@rerecoZeroBiasFakeHLT', '@miniAODDQM']
DQMMessageLoggerSeq is not a possible harvesting type. Available are ['FH_DR_GROUP', 'SusyPostProcessorSequence', 'SUSY_HLT_PhotonMET_pt36', 

so this needs to be further adjusted

@fabiocos
Copy link
Contributor Author

fabiocos commented Nov 1, 2019

this problem seems simply solved by replacing DQMMessageLoggerSeq with DQMMessageLoggerClientSeq in the harvesting part of autoDQM, although @jfernan2 should confirm this is the intended behaviour. The exception anyway is not due to this, but as far as I can see related to missing sequences after the revision

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f8fe4d/3293/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939026
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2938684
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@fabiocos
Copy link
Contributor Author

fabiocos commented Nov 1, 2019

@jfernan2 ok, I think the source of the problem is the revision of the SiStrip rerecoZeroBias and rerecoZeroBiasFakeHLT

@jfernan2
Copy link
Contributor

jfernan2 commented Dec 2, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants