Redefine (in)valid GEM digis and pads

[dildick]

PR description:

PR #24356 reset the begin pad as 0 instead of 1. This broke a function in the GEM-CSC trigger. To fix it, I redefine when strips, pads and clusters are valid. Default strips/pads are now initialized with bx -99 and strip/pad number 2^16-1.

PR validation:

I checked that it runs with WF 22034.

if this PR is a backport please specify the original PR:

N/A

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28335/12598

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/GEMDigi

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@jshlee, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3316/console Started: 2019/11/02 19:27

[cmsbuild]

+1
Tested at: 7bae02c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a6b1a/3316/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a6b1a/3316/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939026
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2938683
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[kpedro88]

+upgrade

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@dildick are we sure this does not interfere with existing datasets? I mean that these values cannot be assumed by old good data, and therefore their state of being good is unchanged?

[dildick]

@fabiocos Correct. GEM BX value is 0 for in-time hits, while the GEM strip number is maximum 768.

[fabiocos]

+1