[HGCal] HGCalValidation: added hitCalibration for web page

[yguler]

PR description:

This PR includes updates, which have been done hit Calibration plot for HGCalValidation.

hgcalPlots.py and makeHGCalValidationPlots.py files are modified to read the HGCalHitCalibration folder in the DQM file and plot it in a webpage.

PR validation:

python Validation/HGCalValidation/scripts/makeHGCalValidationPlots.py DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO.root --outputDir HGCalHitCalibration --no-ratio --png --html-sample TTbar_14TeV --html-validation-name hitCalibration --subdirprefix layerclusters --separate --collection hitCalibration

http://yalcin.web.cern.ch/yalcin/HGCalHitCalibration/

@apsallid, @felicepantaleo , @rovere, @bsunanda,

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28337/12602

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28337/12602/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28337/12602/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[jfernan2]

Hi @yguler, could you please make sure that subsystem name appears in the title of the PR?

[jfernan2]

@yguler please add a description and the validation performed

[jfernan2]

Hi @yguler, I can't seem to find you in DQM contacts list. Could you please briefly introduce yourself?

[fabiocos]

@yguler could you please:

• give this PR a meaningful title;

• solve the conflicts.

If you have no time to act on this PR now, please close it and reopen when ready.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28337/12823

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @yguler for master.

It involves the following packages:

Validation/HGCalValidation

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @bsunanda, @rovere, @lgray, @cseez, @apsallid, @pfs, @deguio, @kpedro88 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3548/console Started: 2019/11/20 09:13

[fabiocos]

@yguler please update the title, we use it in the release-notes to know what was done in each PR, "Validation" sounds meaningless in this context

[apsallid]

@yguler

In the title of the PR add [HGCal] in the beginning plus some nicely descriptive title of the work.
Also, in the description mention sth like (feel free to adjust/change it as you like):

As part of the Validation of campaings regurarly announced from PdmV and UPSG, HGCal wants to monitor
the performance of the rechit calibration among other objects. Usually, RelMon and DQM GUI
is being used for this task. However, in order to quantify the performance of certain clustering algorithms or optimizing the same algorithm or checking different calibration algorithms or inspect the plots in the DQM file easier, we include in the webpage results
from HGCalHitCalibration DQM folder.

In the validation part give the link to your webpage with the plots.

At the end add all people involved with the @ symbol plus some more:

@apsallid, @felicepantaleo , @rovere, @bsunanda plus shuichi github i do not know.

Most of those people are in cmsbot so they will take it automatically, but I believe is a good practice.

Finally, to the core of the work. You are changing only the basic script, if i am not mistaken. You should also add your work on the hgcalPlots.py file.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28337/12832

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #28337 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2412bc/3548/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2936360
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2936017
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3559/console Started: 2019/11/20 17:16

[cmsbuild]

+1
Tested at: 6df7a53
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2412bc/3559/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2412bc/3559/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2936360
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2936018
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[jfernan2]

+1
@yguler I understand the changes are for internal use, the pR is not modifying any workflow

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1