Run3-hcx239 Attempt to make HcalSimulationParameters to be read in for dd4hep

[bsunanda]

PR description:

Attempt to make HcalSimulationParameters created from dd4hep as well as from ddd

PR validation:

There are 2 cfg's in Geometry/HGCalCommonData/test/data/runHcalSimParameterAnalyzer_cfg.py (DDD) and Geometry/HGCalCommonData/test/data/runHcalSimParameterTest_cfg.py (dd4hep) to test these

if this PR is a backport please specify the original PR:

Nothing special

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28381/12712

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28381/12712/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28381/12712/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28381/12713

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HcalAlgo
Geometry/HcalCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3469/console Started: 2019/11/13 19:39

[cmsbuild]

+1
Tested at: c953eb5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5b871/3469/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5b871/3469/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2936360
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2936017
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[ianna]

@bsunanda - please, rebase

[bsunanda]

Ianna has taken the code from here, modified and saved it in #28391. There is nothing more to be added from this.