Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate and simplify MTD modifiers #28387

Merged
merged 3 commits into from Nov 17, 2019
Merged

Conversation

kpedro88
Copy link
Contributor

PR description:

Addresses part of #27450:

  • merge the modifiers phase2_timing_layer and phase2_timing_layer_bar
  • remove the modifier phase2_timing_layer_tile
  • simplify the naming of Phase2 top-level Eras (since only Eras appended with "_timing_layer_bar" are used)

No changes in C++ code are made here; those are left to the MTD expert developers.

Additionally, the changes are propagated to the various test configs scattered throughout CMSSW. Normally I do not guarantee support for such configs, but in this case it was a one-line command to update them.

PR validation:

Ran workflow 20434.0 successfully.

@kpedro88
Copy link
Contributor Author

please test

@ianna
Copy link
Contributor

ianna commented Nov 13, 2019

+1

@chayanit
Copy link

+1

@jfernan2
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor Author

+upgrade

@slava77
Copy link
Contributor

slava77 commented Nov 13, 2019

+1

for #28387 b6e659a

  • changes are essentially technical for reco configs (consolidation of phase2_timing_layer and phase2_timing_layer_bar modifiers into one)
  • jenkins tests pass and comparisons with the baseline show no differences

@civanch
Copy link
Contributor

civanch commented Nov 15, 2019

+1

@fabiocos
Copy link
Contributor

+operations

the update of central configurations is coherent with the target of the this PR

@fabiocos
Copy link
Contributor

+1

@rekovic the update in L1T configuration looks straightforward

@fabiocos
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment