Merge ME0Trigger into L1TGEM #28420
Merge ME0Trigger into L1TGEM #28420
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28420/12809
|
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages: L1Trigger/L1TGEM @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: d512d52 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found compilation warning when building: See details on the summary page. |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
cmsbuild
added
code-checks-pending
comparison-pending
and removed
code-checks-approved
comparison-notrun
tests-rejected
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28420/12820
|
|
Pull request #28420 was updated. @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
| /** Max values of trigger labels for all ME0s; | ||
| * used to construct TMB processors. | ||
| */ | ||
| enum trig_me0s { MAX_ENDCAPS = 2, MAX_CHAMBERS = 18 }; |
There was a problem hiding this comment.
eventually, it would be nice to avoid duplicating these values among different headers (e.g. this one and ME0TriggerPseudoBuilder.h below)
There was a problem hiding this comment.
Absolutely, this should be obtained from a common file. Better yet, obtain it from the ME0Geometry.
|
+upgrade |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
+1 |
dildick
deleted the
from-CMSSW_11_0_X_2019-11-15-1100-merge-ME0Trigger-into-L1TGEM
branch
PR description:
This PR consolidates all GEM trigger primitive producers from
L1Trigger/ME0TriggerandL1Trigger/L1TGEMinto a single package (L1TGEM). This is necessary to absorb the ME0 system into the GEM system later on. I removed the now obsolete producerME0PadDigiClusterProducer. I also removed the obsolete option in the ME0TMB to run a future realistic ME0 track segment builder on ME0 pad clusters, since the ME0 system will use pads directly.Note: this PR is a scaled-back version of #28419 as the coordinate conversion is still under discussion.
PR validation
I tested it with WF 22034.0
if this PR is a backport please specify the original PR:
N/A
@tahuang1991