[CC8] unit test fixed, no need to use static ServiceToken and Registry

[smuzaffar]

PR description:

These unit tests are failing in CC8 IBs. Using non-static ServiceToken and Registry fixes these.
@Dr15Jones , could it be that there is some double delete going on in ServiceToken/Registry? The error we get is

==== Test "testFrontier" ====
# Connecting with db in frontier://FrontierProd/CMS_CONDITIONS
Loaded size=90714
free(): corrupted unsorted chunks
/bin/sh: line 1: 18858 Aborted                 testFrontier

---> test testFrontier had ERRORS

PR validation:

Locally build/run and all unit tests of this package now runs successfully for CentOS8

Singularity> cat logs/cc8_amd64_gcc8/testing.log | grep '^---> test '
---> test testReadWritePayloads succeeded
---> test testRunInfo succeeded
---> test testGroupSelection succeeded
---> test testFrontier succeeded
---> test testConditionDatabase_2 succeeded
---> test testPayloadProxy succeeded
---> test testRootStreaming succeeded
---> test testConditionDatabase_0 succeeded
---> test testConnectionPool had ERRORS
---> test testConditionDatabase_1 succeeded
---> test condTestRegression succeeded

[smuzaffar]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28425/12814

• This PR adds an extra 16KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3530/console Started: 2019/11/19 16:12

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CondCore/CondDB

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

could it be that there is some double delete going on in ServiceToken/Registry?

The classes in question are meant to be temporaries with lifetimes shorter than the central parts of the plugin system. The use of static breaks the lifetime requirement and leads to the problem.

[smuzaffar]

any idea why we do not get this error for SLC6/7?

[cmsbuild]

+1
Tested at: ebb94c9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4186c4/3530/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4186c4/3530/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2936360
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2936018
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[smuzaffar]

@ggovi can you please check and sign this?

[fabiocos]

+1

[fabiocos]

merge