Explicitly copy scripts which should end up in cmssw/bin directory

[smuzaffar]

As new Build rules only copy scripts with execution permission , so explicitly copy some extrra scripts (perl Module, python lib and config files) which are needed by unit tests

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5367
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3557/console Started: 2019/11/20 15:55

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28434/12845

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm
Utilities/ReleaseScripts

@smuzaffar, @Dr15Jones, @christopheralanwest, @tocheng, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@adewit, @wddgit, @Martin-Grunewald, @tocheng, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Tested at: cbf747b

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8aad8/3557/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test TestFWCorePythonFrameworkDriver had ERRORS
---> test materialBudgetTrackerPlots had ERRORS

[cmsbuild]

Comparison job queued.

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3564/console Started: 2019/11/20 22:26

[fabiocos]

@smuzaffar XML2Python.py looks duplicated between Utilities/ReleaseScripts and FWCore/PythonUtilities, although the two files are not strictly the same

[cmsbuild]

+1
Tested at: 618d90e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d08488/3564/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8aad8/3557/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 1560 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2936360
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2936017
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d08488/3564/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2936360
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2936018
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[smuzaffar]

@fabiocos , XML2Python.py is in three places

• PhysicsTools/PythonAnalysis/python/XML2Python.py
• FWCore/PythonUtilities/python/XML2Python.py
• Utilities/ReleaseScripts/scripts/XML2Python.py
  only the one from Utilities/ReleaseScripts ends up in cmssw/bin directory. Other two are in PYTHONPATH (i.e. cmssw/python directory).

[smuzaffar]

+core
@fabiocos , can we get this in next IB. This is needed sot that we can get new build rules ( cms-sw/cmsdist#5367 ) in DEVEL IBs

[fabiocos]

@smuzaffar concerning #28434 (comment) I wonder whether it makes sense to have multiple variants of the same utility in different places (as I happened to look at FWCore/PythonUtilities for #28439 )

[fabiocos]

+1

@christopheralanwest @tlampen this looks technical, please check anyway

[fabiocos]

merge

[christopheralanwest]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.